matchMedia support #31
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issackjohn
force-pushed
the
issack/matchMediaSupport
branch
from
63d455b to
a094e2c
Compare
* Write dev files to different location. * Using root code style. * Remove unused Prettier and ESLint configuration files from responsive design directory * Update scrollIntoView method to accept options parameter for better control * change scroll behavior to instant * Refactor Responsive-Design tests to use async functions * Rename output directory from dev-dist to build-dev in configuration files * Re-install resize observer
issackjohn
force-pushed
the
responsive-design
branch
from
b1de2cf to
8552b1e
Compare
This reverts commit 9ca8ba9.
… for improved performance
issackjohn
force-pushed
the
issack/matchMediaSupport
branch
from
08e661c to
0c6ce4b
Compare
issackjohn
force-pushed
the
responsive-design
branch
from
b6e0396 to
d049bc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on enhancing the
experimental/responsive-designproject by refining recipe data, updating UI components, and improving responsive design breakpoints. The key changes include adding areviewsfield to all recipes, simplifying recipe tags, redesigning theAppRibbonandChatWindowcomponents, and adjusting responsive breakpoints for better layout adaptability.Recipe Data Updates:
reviewsfield to all recipes inrecipes.jsto display the number of user reviews for each recipe. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]tagsfield for all recipes by removing less critical tags to streamline categorization. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]UI Component Redesigns:
AppRibboncomponent inapp-ribbon.jswith a new design, including teal-themed styles, rounded borders, and improved button layouts.ChatWindowcomponent inchat-window.jswith enhanced button styles, background colors, and focus states for a more modern look.Responsive Design Improvements:
_updateVisibleButtonsmethod ofapp-ribbon.jsto ensure better responsiveness for larger screen sizes.Minor Text Updates:
ribbon-buttons.jsfor brevity and clarity.