Skip to content

Commit

Permalink
audio: remove HAS_AUDIO
Browse files Browse the repository at this point in the history
Several targets can have wavcapture/-soundhw support via PCI cards.
HAS_AUDIO is a useless limitation, remove it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1366303444-24620-4-git-send-email-pbonzini@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
  • Loading branch information
bonzini authored and Anthony Liguori committed Apr 29, 2013
1 parent 36cd6f6 commit ffa48cf
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 41 deletions.
18 changes: 0 additions & 18 deletions arch_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,6 @@ SaveVMHandlers savevm_ram_handlers = {
.cancel = ram_migration_cancel,
};

#ifdef HAS_AUDIO
struct soundhw {
const char *name;
const char *descr;
Expand Down Expand Up @@ -1006,14 +1005,6 @@ void audio_init(ISABus *isa_bus, PCIBus *pci_bus)
}
}
}
#else
void select_soundhw(const char *optarg)
{
}
void audio_init(ISABus *isa_bus, PCIBus *pci_bus)
{
}
#endif

int qemu_uuid_parse(const char *str, uint8_t *uuid)
{
Expand Down Expand Up @@ -1069,15 +1060,6 @@ void cpudef_init(void)
#endif
}

int audio_available(void)
{
#ifdef HAS_AUDIO
return 1;
#else
return 0;
#endif
}

int tcg_available(void)
{
return 1;
Expand Down
8 changes: 0 additions & 8 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -4457,14 +4457,6 @@ alpha)
;;
esac

if test "$target_softmmu" = "yes" ; then
case "$TARGET_BASE_ARCH" in
arm|lm32|i386|mips|ppc)
cflags="-DHAS_AUDIO $cflags"
;;
esac
fi

if test "$gprof" = "yes" ; then
echo "TARGET_GPROF=yes" >> $config_target_mak
if test "$target_linux_user" = "yes" ; then
Expand Down
4 changes: 0 additions & 4 deletions hmp-commands.hx
Original file line number Diff line number Diff line change
Expand Up @@ -736,15 +736,13 @@ info mice
@end example
ETEXI

#ifdef HAS_AUDIO
{
.name = "wavcapture",
.args_type = "path:F,freq:i?,bits:i?,nchannels:i?",
.params = "path [frequency [bits [channels]]]",
.help = "capture audio to a wave file (default frequency=44100 bits=16 channels=2)",
.mhandler.cmd = do_wav_capture,
},
#endif
STEXI
@item wavcapture @var{filename} [@var{frequency} [@var{bits} [@var{channels}]]]
@findex wavcapture
Expand All @@ -759,15 +757,13 @@ Defaults:
@end itemize
ETEXI

#ifdef HAS_AUDIO
{
.name = "stopcapture",
.args_type = "n:i",
.params = "capture index",
.help = "stop capture",
.mhandler.cmd = do_stop_capture,
},
#endif
STEXI
@item stopcapture @var{index}
@findex stopcapture
Expand Down
1 change: 0 additions & 1 deletion include/sysemu/arch_init.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ void select_soundhw(const char *optarg);
void do_acpitable_option(const QemuOpts *opts);
void do_smbios_option(const char *optarg);
void cpudef_init(void);
int audio_available(void);
void audio_init(ISABus *isa_bus, PCIBus *pci_bus);
int tcg_available(void);
int kvm_available(void);
Expand Down
2 changes: 0 additions & 2 deletions monitor.c
Original file line number Diff line number Diff line change
Expand Up @@ -1862,7 +1862,6 @@ static void do_info_capture(Monitor *mon, const QDict *qdict)
}
}

#ifdef HAS_AUDIO
static void do_stop_capture(Monitor *mon, const QDict *qdict)
{
int i;
Expand Down Expand Up @@ -1903,7 +1902,6 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict)
}
QLIST_INSERT_HEAD (&capture_head, s, entries);
}
#endif

static qemu_acl *find_acl(Monitor *mon, const char *name)
{
Expand Down
8 changes: 0 additions & 8 deletions vl.c
Original file line number Diff line number Diff line change
Expand Up @@ -3232,18 +3232,10 @@ int main(int argc, char **argv, char **envp)
add_device_config(DEV_BT, optarg);
break;
case QEMU_OPTION_audio_help:
if (!(audio_available())) {
printf("Option %s not supported for this target\n", popt->name);
exit(1);
}
AUD_help ();
exit (0);
break;
case QEMU_OPTION_soundhw:
if (!(audio_available())) {
printf("Option %s not supported for this target\n", popt->name);
exit(1);
}
select_soundhw (optarg);
break;
case QEMU_OPTION_h:
Expand Down

0 comments on commit ffa48cf

Please sign in to comment.