Skip to content

Commit

Permalink
replay: finish record/replay before closing the disks
Browse files Browse the repository at this point in the history
After recent updates block devices cannot be closed on qemu exit.
This happens due to the block request polling when replay is not finished.
Therefore now we stop execution recording before closing the block devices.

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  • Loading branch information
Dovgalyuk authored and kevmw committed Oct 14, 2019
1 parent c8aa789 commit ae25dcc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions replay/replay.c
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,8 @@ void replay_finish(void)
g_free(replay_snapshot);
replay_snapshot = NULL;

replay_mode = REPLAY_MODE_NONE;

replay_finish_events();
}

Expand Down
1 change: 1 addition & 0 deletions vl.c
Original file line number Diff line number Diff line change
Expand Up @@ -4524,6 +4524,7 @@ int main(int argc, char **argv, char **envp)

/* No more vcpu or device emulation activity beyond this point */
vm_shutdown();
replay_finish();

job_cancel_sync_all();
bdrv_close_all();
Expand Down

0 comments on commit ae25dcc

Please sign in to comment.