Skip to content

Commit

Permalink
dma/pl330: Fix buffer depth
Browse files Browse the repository at this point in the history
This is the product of the data-width and the depth arguments, I.e the
depth of the FIFO is in terms of data entries and not bytes (which is
what the original implementation was suggesting). Fix.

Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: c34de31031511538ccdb3164b48ee8a6a973ebd4.1393372019.git.peter.crosthwaite@xilinx.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  • Loading branch information
pete128 authored and pm215 committed Feb 26, 2014
1 parent 432a0a1 commit a5ae7e3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hw/dma/pl330.c
Original file line number Diff line number Diff line change
Expand Up @@ -1606,7 +1606,7 @@ static void pl330_realize(DeviceState *dev, Error **errp)

pl330_queue_init(&s->read_queue, s->rd_q_dep, s);
pl330_queue_init(&s->write_queue, s->wr_q_dep, s);
pl330_fifo_init(&s->fifo, s->data_buffer_dep);
pl330_fifo_init(&s->fifo, s->data_width / 4 * s->data_buffer_dep);
}

static Property pl330_properties[] = {
Expand Down

0 comments on commit a5ae7e3

Please sign in to comment.