Skip to content

Commit

Permalink
qapi: convert query-name
Browse files Browse the repository at this point in the history
A simple example conversion 'info name'.  This also adds the new files for
QMP and HMP.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
  • Loading branch information
Anthony Liguori authored and Luiz Capitulino committed Oct 4, 2011
1 parent 303b54b commit 48a32be
Show file tree
Hide file tree
Showing 7 changed files with 108 additions and 28 deletions.
1 change: 1 addition & 0 deletions Makefile.objs
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@ qapi-nested-y += qmp-registry.o qmp-dispatch.o
qapi-obj-y = $(addprefix qapi/, $(qapi-nested-y))

common-obj-y += qmp-marshal.o qapi-visit.o qapi-types.o $(qapi-obj-y)
common-obj-y += qmp.o hmp.o

######################################################################
# guest agent
Expand Down
26 changes: 26 additions & 0 deletions hmp.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/*
* Human Monitor Interface
*
* Copyright IBM, Corp. 2011
*
* Authors:
* Anthony Liguori <aliguori@us.ibm.com>
*
* This work is licensed under the terms of the GNU GPL, version 2. See
* the COPYING file in the top-level directory.
*
*/

#include "hmp.h"
#include "qmp-commands.h"

void hmp_info_name(Monitor *mon)
{
NameInfo *info;

info = qmp_query_name(NULL);
if (info->has_name) {
monitor_printf(mon, "%s\n", info->name);
}
qapi_free_NameInfo(info);
}
22 changes: 22 additions & 0 deletions hmp.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/*
* Human Monitor Interface
*
* Copyright IBM, Corp. 2011
*
* Authors:
* Anthony Liguori <aliguori@us.ibm.com>
*
* This work is licensed under the terms of the GNU GPL, version 2. See
* the COPYING file in the top-level directory.
*
*/

#ifndef HMP_H
#define HMP_H

#include "qemu-common.h"
#include "qapi-types.h"

void hmp_info_name(Monitor *mon);

#endif
31 changes: 3 additions & 28 deletions monitor.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@
#include "trace/control.h"
#include "ui/qemu-spice.h"
#include "memory.h"
#include "qmp-commands.h"
#include "hmp.h"

//#define DEBUG
//#define DEBUG_COMPLETION
Expand Down Expand Up @@ -760,24 +762,6 @@ static void do_info_version(Monitor *mon, QObject **ret_data)
'micro': %d }, 'package': %s }", major, minor, micro, QEMU_PKGVERSION);
}

static void do_info_name_print(Monitor *mon, const QObject *data)
{
QDict *qdict;

qdict = qobject_to_qdict(data);
if (qdict_size(qdict) == 0) {
return;
}

monitor_printf(mon, "%s\n", qdict_get_str(qdict, "name"));
}

static void do_info_name(Monitor *mon, QObject **ret_data)
{
*ret_data = qemu_name ? qobject_from_jsonf("{'name': %s }", qemu_name) :
qobject_from_jsonf("{}");
}

static QObject *get_cmd_dict(const char *name)
{
const char *p;
Expand Down Expand Up @@ -3094,8 +3078,7 @@ static const mon_cmd_t info_cmds[] = {
.args_type = "",
.params = "",
.help = "show the current VM name",
.user_print = do_info_name_print,
.mhandler.info_new = do_info_name,
.mhandler.info = hmp_info_name,
},
{
.name = "uuid",
Expand Down Expand Up @@ -3286,14 +3269,6 @@ static const mon_cmd_t qmp_query_cmds[] = {
.mhandler.info_new = do_info_spice,
},
#endif
{
.name = "name",
.args_type = "",
.params = "",
.help = "show the current VM name",
.user_print = do_info_name_print,
.mhandler.info_new = do_info_name,
},
{
.name = "uuid",
.args_type = "",
Expand Down
22 changes: 22 additions & 0 deletions qapi-schema.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
# -*- Mode: Python -*-
#
# QAPI Schema

##
# @NameInfo:
#
# Guest name information.
#
# @name: #optional The name of the guest
#
# Since 0.14.0
##
{ 'type': 'NameInfo', 'data': {'*name': 'str'} }

##
# @query-name:
#
# Return the name information of a guest.
#
# Returns: @NameInfo of the guest
#
# Since 0.14.0
##
{ 'command': 'query-name', 'returns': 'NameInfo' }
6 changes: 6 additions & 0 deletions qmp-commands.hx
Original file line number Diff line number Diff line change
Expand Up @@ -1780,6 +1780,12 @@ Example:

EQMP

{
.name = "query-name",
.args_type = "",
.mhandler.cmd_new = qmp_marshal_input_query_name,
},

SQMP
query-uuid
----------
Expand Down
28 changes: 28 additions & 0 deletions qmp.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
/*
* QEMU Management Protocol
*
* Copyright IBM, Corp. 2011
*
* Authors:
* Anthony Liguori <aliguori@us.ibm.com>
*
* This work is licensed under the terms of the GNU GPL, version 2. See
* the COPYING file in the top-level directory.
*
*/

#include "qemu-common.h"
#include "sysemu.h"
#include "qmp-commands.h"

NameInfo *qmp_query_name(Error **errp)
{
NameInfo *info = g_malloc0(sizeof(*info));

if (qemu_name) {
info->has_name = true;
info->name = g_strdup(qemu_name);
}

return info;
}

0 comments on commit 48a32be

Please sign in to comment.