Skip to content

Conversation

@hkctkuy
Copy link
Member

@hkctkuy hkctkuy commented May 10, 2025

Nobody wanted it, nobody asked it, but we did it anyway.

@hkctkuy hkctkuy requested a review from SweetVishnya May 10, 2025 15:15
@hkctkuy hkctkuy marked this pull request as draft May 10, 2025 15:16
@codecov
Copy link

codecov bot commented May 10, 2025

Codecov Report

Attention: Patch coverage is 77.47508% with 339 lines in your changes missing coverage. Please review.

Project coverage is 64.85%. Comparing base (2a5d294) to head (740675b).

Files with missing lines Patch % Lines
casr/src/mode/mod.rs 76.92% 39 Missing ⚠️
casr/src/mode/go.rs 0.00% 32 Missing ⚠️
casr/src/mode/rust.rs 0.00% 32 Missing ⚠️
casr/src/mode/java.rs 61.84% 29 Missing ⚠️
libcasr/src/gdb/exploitable.rs 39.53% 26 Missing ⚠️
libcasr/src/go.rs 13.33% 26 Missing ⚠️
libcasr/src/rust.rs 13.33% 26 Missing ⚠️
casr/src/mode/msan.rs 28.12% 23 Missing ⚠️
casr/src/run/gdb.rs 80.30% 13 Missing ⚠️
casr/src/mode/lua.rs 67.56% 12 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   66.21%   64.85%   -1.37%     
==========================================
  Files          34       52      +18     
  Lines        7640     7859     +219     
==========================================
+ Hits         5059     5097      +38     
- Misses       2581     2762     +181     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hkctkuy hkctkuy force-pushed the casr-common branch 3 times, most recently from c6e0e4c to 1a92ab2 Compare May 17, 2025 14:06
@@ -0,0 +1,121 @@
//! Gdb module implements `ParseStacktrace`, `Exception` and `Severity` traits for Gdb output.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These docs should be updated, I suppose

maps: Vec<String>,
report: Vec<String>,
stream: String,
stacktrace: Option<Stacktrace>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add docs to all fields

Copy link
Member Author

@hkctkuy hkctkuy Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add docs for private fields?

@hkctkuy hkctkuy self-assigned this Sep 9, 2025
@hkctkuy hkctkuy marked this pull request as ready for review September 9, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants