-
Notifications
You must be signed in to change notification settings - Fork 29
Common casr tool #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Common casr tool #259
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #259 +/- ##
==========================================
- Coverage 66.21% 64.85% -1.37%
==========================================
Files 34 52 +18
Lines 7640 7859 +219
==========================================
+ Hits 5059 5097 +38
- Misses 2581 2762 +181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c6e0e4c to
1a92ab2
Compare
| @@ -0,0 +1,121 @@ | |||
| //! Gdb module implements `ParseStacktrace`, `Exception` and `Severity` traits for Gdb output. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These docs should be updated, I suppose
| maps: Vec<String>, | ||
| report: Vec<String>, | ||
| stream: String, | ||
| stacktrace: Option<Stacktrace>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add docs to all fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add docs for private fields?
Nobody wanted it, nobody asked it, but we did it anyway.