Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoScalingGroups detection improved. #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

AutoScalingGroups detection improved. #13

wants to merge 2 commits into from

Conversation

viktor-kurchenko
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko commented Mar 17, 2023 •
edited
Loading

It looks like Autoscale groups can be detected only via tags.
Now it will try to detect Autoscale groups via the below tags (+ tag provided in params):

  • eks:cluster-name:
  • k8s.io/cluster-autoscaler/:owned
  • kubernetes.io/cluster/:owned
  • k8s.io/cluster/:owned

@viktor-kurchenko
AutoScalingGroups detection improved.
720c94a 
Signed-off-by: Viktor Kurchenko <viktor.kurchenko@isovalent.com>
soggiest
soggiest suggested changes Mar 17, 2023
View reviewed changes
vpc.go Show resolved Hide resolved
autoscalinggroup.go Outdated Show resolved Hide resolved
autoscalinggroup.go Outdated Show resolved Hide resolved
@viktor-kurchenko
Code review fixed.
a4a0fb1 
Signed-off-by: Viktor Kurchenko <viktor.kurchenko@isovalent.com>
nbusseneau
nbusseneau approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I thought the autoscaling groups were already handled. I take it you've had an issue with them not being handled by the tool? In any case, LGTM.

@tklauser tklauser removed their request for review March 28, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soggiest soggiest soggiest requested changes

@nbusseneau nbusseneau nbusseneau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viktor-kurchenko @nbusseneau @soggiest