Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some MySQL 8 Exceptions #2088

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Fixes some MySQL 8 Exceptions #2088

merged 1 commit into from
Nov 19, 2019

Conversation

3lding
Copy link
Contributor

@3lding 3lding commented Oct 24, 2019

Got this error in the contao logs:

[2019-10-24 18:22:40] app.CRITICAL: An exception occurred. {"exception":"[object] (Doctrine\\DBAL\\Exception\\SyntaxErrorException(code: 0): An exception occurred while executing 'SELECT tl_iso_productcache.* FROM tl_iso_productcache WHERE uniqid='[anonymized-id]' AND (keywords='' OR keywords='') AND (expires>1571934160 OR expires=0) AND groups='' LIMIT 0,1':\n\nSQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'groups='' LIMIT 0,1' at line 1 at [anonymized]/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php:99, Doctrine\\DBAL\\Driver\\PDOException(code: 42000): SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'groups='' LIMIT 0,1' at line 1 at [anonymized]/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:109, PDOException(code: 42000): SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'groups='' LIMIT 0,1' at line 1 at [anonymized]/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:107)"} []

Maybe my modification is a "dirty hack" but it works with MySQL 8 and the website is loading without any errors.

Got this error in the contao logs:
[2019-10-24 18:22:40] app.CRITICAL: An exception occurred. {"exception":"[object] (Doctrine\\DBAL\\Exception\\SyntaxErrorException(code: 0): An exception occurred while executing 'SELECT tl_iso_productcache.* FROM tl_iso_productcache WHERE uniqid='[anonymized-id]' AND (keywords='' OR keywords='') AND (expires>1571934160 OR expires=0) AND groups='' LIMIT 0,1':\n\nSQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'groups='' LIMIT 0,1' at line 1 at [anonymized]/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php:99, Doctrine\\DBAL\\Driver\\PDOException(code: 42000): SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'groups='' LIMIT 0,1' at line 1 at [anonymized]/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:109, PDOException(code: 42000): SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'groups='' LIMIT 0,1' at line 1 at [anonymized]/vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:107)"} []
----
Maybe my modification is a "dirty hack" but it works with MySQL 8 and the website is loading without any errors.
@aschempp
Copy link
Member

Related to #2086, contao/contao#727, contao/contao#847

I actually like this simple fix, but it wont fix everything and everywhere. I wonder if we still need these adjustments with the fixed DBAL implementation, maybe you can test this locally? Unfortunately I don't have MySQL 8 at hand.

@loilo
Copy link

loilo commented Oct 30, 2019

The point is that there has not been a release of the DBAL package for almost a year. The fix has been merged, but no version containing it has been published.

@aschempp
Copy link
Member

see doctrine/dbal#3674

@aschempp aschempp added the bug label Nov 19, 2019
@aschempp aschempp added this to the 2.6 milestone Nov 19, 2019
@aschempp aschempp changed the base branch from master to hotfix/2.6.4 November 19, 2019 17:45
@aschempp aschempp merged commit 18804e6 into isotope:hotfix/2.6.4 Nov 19, 2019
@aschempp aschempp modified the milestones: 2.6, 2.6.4 Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants