Missing stacktrace basic reproduction test #14
Conversation
| const _kContainerName = 'postgres-dart-test'; | ||
|
|
||
| Future<void> startPostgresContainer() async { | ||
| setUpAll(() async { |
There was a problem hiding this comment.
let's also add a teardownAll that stops the container
test/docker.dart
Outdated
|
|
||
| const _kContainerName = 'postgres-dart-test'; | ||
|
|
||
| Future<void> startPostgresContainer() async { |
There was a problem hiding this comment.
I think async happens only in the setupAll, so this method should rather be something like void usePostgresDocker() {.
test/docker.dart
Outdated
| }); | ||
| } | ||
|
|
||
| Future<bool> isPostgresContainerRunning() async { |
| } | ||
|
|
||
| await startPostgres( | ||
| name: _kContainerName, |
There was a problem hiding this comment.
This is a nice thing to have here, I haven't really thought that you'd match the CI's config, but it makes sense.
test/error_handling_test.dart
Outdated
|
|
||
| import 'docker.dart'; | ||
|
|
||
| Future<void> main() async { |
There was a problem hiding this comment.
Test main can be void main() { without the async block.
|
@isoos I've updated the PR with the comments |
|
this looks good and it is a good baseline for debugging... can I just merge it? |
Yes, go ahead! I've tried debugging it, but I didn't know where to start because of the event system the library uses. |
isoos
changed the title
There are a few places where one can start putting e.g. debug/print statements:
Feel free to update the issue if you find something, I'll try to find time to debug this over the weekend too... |
@isoos Here is a basic test case which reproduces #13 . I've included the docker_process package, so it will run a local postgres container.