Stop using Capture phase events #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coofercat
changed the title
|
They are also on line 240-242 |
|
...so they are (now removed) #untested ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #390 - elements further "down" DOM can't stop events reaching the Carousel because the Carousel uses Capture events, which start in the root of the DOM and work their way down to child elements. As such, they happen before anything inside the Carousel has a chance to handle them. This means it's impossible to prevent the Carousel from sliding from a child element (for example, an interactive component in a Slide).
Probably my lack of relevant skills, but I couldn't get the dependencies of this project to resolve in a clean VM, and after some hackery to get around that I got some Vue render-time errors related to refs which I didn't understand. As such, I haven't been able to properly test this change.