Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test, do not merge] Support python 312 mirror #6977

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
6607677
python3.12 support
swheaton Mar 25, 2024
4ba2d39
tensorboard bump
swheaton Mar 25, 2024
17baa25
typo
swheaton Mar 25, 2024
fae3dff
what is happening with my typo fixing
swheaton Mar 25, 2024
8a2cc17
bump scipy
swheaton Mar 25, 2024
66f8800
unrelated style check fix
swheaton Mar 25, 2024
5303613
scipy 1.11.4 required for python3.12, otherwise unchanged
swheaton Mar 25, 2024
e5dd29c
tensorboard 2.16.2 required for python3.12, otherwise unchanged
swheaton Mar 25, 2024
15abf18
fix improper error fstring
swheaton Mar 26, 2024
e9a6d71
Merge branch 'main' of github.com:isl-org/Open3D into support-python-312
ssheorey Jul 13, 2024
d96ecbf
Update windows CUDA version to match Linux, TF version, torch as late…
ssheorey Jul 16, 2024
9e1b5ae
use c++17 if pytorch ops are enabled
benjaminum Aug 14, 2024
da622f4
Merge branch 'main' into support-python-312
benjaminum Aug 14, 2024
1ff496f
update url for Windows CUDA installer
benjaminum Aug 14, 2024
164a01a
Update Windows MSVC to CUDA 11.8
ssheorey Aug 20, 2024
ea0c66d
Merge branch 'main' into support-python-312
ssheorey Aug 20, 2024
0c4132b
Merge branch 'main' of github.com:isl-org/Open3D into support-python-312
ssheorey Aug 20, 2024
945e35d
Always obey CMAKE_CUDA_ARCHITECTURES if used.
ssheorey Aug 22, 2024
2222fcb
use shared_ptr to capture array in lambda
benjaminum Aug 28, 2024
35ee51e
fix tf ml ops tests on macos
benjaminum Sep 1, 2024
170b650
apply style
benjaminum Sep 4, 2024
68fca39
Install thrust with CUDA
ssheorey Sep 7, 2024
6314046
Remove fmt formatter for embree RTCError to fix macOS error
ssheorey Sep 13, 2024
5cddb82
Merge branch 'main' of github.com:isl-org/Open3D into support-python-312
ssheorey Sep 13, 2024
99bc91f
switch to miniforge
benjaminum Sep 15, 2024
7cdd7e3
use cuda 12.3 as suggested here https://github.com/tensorflow/tensorf…
benjaminum Sep 15, 2024
13699e8
change to cuda 12.1 for pytorch and tensorflow
benjaminum Sep 16, 2024
267df1a
set TORCH_CUDA_ARCH_LIST as workaround for CUDA 12 and Pytorch <2.4
benjaminum Sep 17, 2024
8fc1bd7
Merge branch 'main' into bu/support-python-312-mirror
benjaminum Sep 18, 2024
cc01512
fix failed merge
benjaminum Sep 19, 2024
9856186
Merge branch 'main' of github.com:isl-org/Open3D into bu/support-pyth…
ssheorey Sep 30, 2024
4ccae42
Match PyTorch ops CUDA arch list to that of Open3D
ssheorey Oct 3, 2024
b6cc832
do not install cuda pytorch before build_pip_package
ssheorey Oct 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' of github.com:isl-org/Open3D into support-python-312
  • Loading branch information
ssheorey committed Aug 20, 2024
commit 0c4132bee11b1bef01ca9be1108edbbf872be400
2 changes: 1 addition & 1 deletion 3rdparty/stdgpu/stdgpu.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ExternalProject_Add(
PREFIX stdgpu
# Aug 2024
URL https://github.com/stotko/stdgpu/archive/d57a4905f64fea0e06c56194131ad7a1c7291a16.tar.gz
URL_HASH SHA256=7bb2733b099f7cedc86d2aee7830d128ac1222cfafa34cbaa4e818483c0a93f6
URL_HASH SHA256=c96775aafb44f5a36af96a4b7ec8b2de6b0587c0cf9ed76705306b6dc3b950b5
DOWNLOAD_DIR "${OPEN3D_THIRD_PARTY_DOWNLOAD_DIR}/stdgpu"
UPDATE_COMMAND ""
CMAKE_ARGS
Expand Down
8 changes: 1 addition & 7 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -294,13 +294,7 @@ endif()

# Global flag to set CXX standard.
# This does not affect 3rd party libraries.
# Tensorflow 2.9+ requires cxx_17, but MSVC 19.29 throws errors with C++17
# enabled. ATen in Pytorch 2.2 requires cxx_17
if (BUILD_SYCL_MODULE OR BUILD_TENSORFLOW_OPS OR BUILD_PYTORCH_OPS)
set(CMAKE_CXX_STANDARD 17)
else()
set(CMAKE_CXX_STANDARD 14)
endif()
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_EXTENSIONS OFF) # Improved compatibility

# Suppress warnings for deprecated C++17 functions (stdgpu->thrust with CUDA 11 for MSVC).
Expand Down
6 changes: 4 additions & 2 deletions cpp/open3d/io/file_format/FileASSIMP.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,8 @@ bool ReadTriangleMeshUsingASSIMP(

const auto* scene = importer.ReadFile(filename.c_str(), post_process_flags);
if (!scene) {
utility::LogWarning("ReadTriangleMeshUsingASSIMP error: {}", importer.GetErrorString());
utility::LogWarning("ReadTriangleMeshUsingASSIMP error: {}",
importer.GetErrorString());
return false;
}

Expand Down Expand Up @@ -326,7 +327,8 @@ bool ReadModelUsingAssimp(const std::string& filename,
const auto* scene =
importer.ReadFile(filename.c_str(), kPostProcessFlags_fast);
if (!scene) {
utility::LogWarning("ReadTriangleMeshUsingASSIMP error: {}", importer.GetErrorString());
utility::LogWarning("ReadTriangleMeshUsingASSIMP error: {}",
importer.GetErrorString());
return false;
}

Expand Down
6 changes: 4 additions & 2 deletions cpp/open3d/t/io/file_format/FileASSIMP.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ bool ReadTriangleMeshUsingASSIMP(

const auto* scene = importer.ReadFile(filename.c_str(), post_process_flags);
if (!scene) {
utility::LogWarning("ReadTriangleMeshUsingASSIMP error: {}", importer.GetErrorString());
utility::LogWarning("ReadTriangleMeshUsingASSIMP error: {}",
importer.GetErrorString());
return false;
}

Expand Down Expand Up @@ -470,7 +471,8 @@ bool WriteTriangleMeshUsingASSIMP(const std::string& filename,
// Export
if (exporter.Export(ai_scene.get(), "glb2", filename.c_str()) ==
AI_FAILURE) {
utility::LogWarning("WriteTriangleMeshUsingASSIMP error: {}", exporter.GetErrorString());
utility::LogWarning("WriteTriangleMeshUsingASSIMP error: {}",
exporter.GetErrorString());
return false;
}

Expand Down
22 changes: 11 additions & 11 deletions docs/getting_started.in.rst
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Pip (PyPI)
.. warning::

Versions of ``numpy>=2.0.0`` require ``Open3D>0.18.0`` or the latest development
version of Open3D. If you are using an older version of Open3D, downgrade ``numpy``
version of Open3D. If you are using an older version of Open3D, downgrade ``numpy``
with

.. code-block:: bash
Expand Down Expand Up @@ -96,18 +96,18 @@ version (``HEAD`` of ``main`` branch):
:widths: auto

* - Linux
- `Python 3.8 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d-@OPEN3D_VERSION_FULL@-cp38-cp38-manylinux_2_27_x86_64.whl>`__
- `Python 3.9 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d-@OPEN3D_VERSION_FULL@-cp39-cp39-manylinux_2_27_x86_64.whl>`__
- `Python 3.10 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d-@OPEN3D_VERSION_FULL@-cp310-cp310-manylinux_2_27_x86_64.whl>`__
- `Python 3.11 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d-@OPEN3D_VERSION_FULL@-cp311-cp311-manylinux_2_27_x86_64.whl>`__
- `Python 3.12 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d-@OPEN3D_VERSION_FULL@-cp312-cp312-manylinux_2_27_x86_64.whl>`__
- `Python 3.8 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d-@OPEN3D_VERSION_FULL@-cp38-cp38-manylinux_2_31_x86_64.whl>`__
- `Python 3.9 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d-@OPEN3D_VERSION_FULL@-cp39-cp39-manylinux_2_31_x86_64.whl>`__
- `Python 3.10 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d-@OPEN3D_VERSION_FULL@-cp310-cp310-manylinux_2_31_x86_64.whl>`__
- `Python 3.11 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d-@OPEN3D_VERSION_FULL@-cp311-cp311-manylinux_2_31_x86_64.whl>`__
- `Python 3.12 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d-@OPEN3D_VERSION_FULL@-cp312-cp312-manylinux_2_31_x86_64.whl>`__

* - Linux (CPU)
- `Python 3.8 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d_cpu-@OPEN3D_VERSION_FULL@-cp38-cp38-manylinux_2_27_x86_64.whl>`__
- `Python 3.9 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d_cpu-@OPEN3D_VERSION_FULL@-cp39-cp39-manylinux_2_27_x86_64.whl>`__
- `Python 3.10 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d_cpu-@OPEN3D_VERSION_FULL@-cp310-cp310-manylinux_2_27_x86_64.whl>`__
- `Python 3.11 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d_cpu-@OPEN3D_VERSION_FULL@-cp311-cp311-manylinux_2_27_x86_64.whl>`__
- `Python 3.12 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d_cpu-@OPEN3D_VERSION_FULL@-cp312-cp312-manylinux_2_27_x86_64.whl>`__
- `Python 3.8 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d_cpu-@OPEN3D_VERSION_FULL@-cp38-cp38-manylinux_2_31_x86_64.whl>`__
- `Python 3.9 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d_cpu-@OPEN3D_VERSION_FULL@-cp39-cp39-manylinux_2_31_x86_64.whl>`__
- `Python 3.10 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d_cpu-@OPEN3D_VERSION_FULL@-cp310-cp310-manylinux_2_31_x86_64.whl>`__
- `Python 3.11 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d_cpu-@OPEN3D_VERSION_FULL@-cp311-cp311-manylinux_2_31_x86_64.whl>`__
- `Python 3.12 <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d_cpu-@OPEN3D_VERSION_FULL@-cp312-cp312-manylinux_2_31_x86_64.whl>`__

* - MacOS
- `Python 3.8 (x86_64) <https://github.com/isl-org/Open3D/releases/download/main-devel/open3d-@OPEN3D_VERSION_FULL@-cp38-cp38-macosx_11_0_x86_64.whl>`__
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.