Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC Ninja fixes #6964

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

MSVC Ninja fixes #6964

wants to merge 17 commits into from

Conversation

dbs4261
Copy link
Contributor

@dbs4261 dbs4261 commented Sep 12, 2024

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Not all windows builds use the MSVC generator, for example the CLion can be used as an IDE and dispatch to the MSVC compiler. MSVC creates different names for some libraries eg. libpng-d.lib. This does not happen with the Ninja generator, so these debug libraries cannot be found when using a different generator.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

This PR has cmake check the generator instead of the compiler to determine if these different names should be added. Also updated the tbb target name that is copied for the test.exe target to its namespaced version TBB::tbb.

Copy link

update-docs bot commented Sep 12, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@dbs4261
Copy link
Contributor Author

dbs4261 commented Sep 12, 2024

I don't think these changes are worth updating the changelog, but I'm open to other opinions.

@dbs4261
Copy link
Contributor Author

dbs4261 commented Sep 12, 2024

Hmmm, the rabbit hole goes deeper than I expected. This is not ready to merge yet.

@dbs4261 dbs4261 marked this pull request as draft September 12, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant