-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra documentation build for python examples #6487
Remove extra documentation build for python examples #6487
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, should be fine to replace output docs path with URL.
Thanks! LGTM.
de73980
to
5c908c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @saurabheights something is not quite right with the updates:
- The generated docs are only 210MB compared to >400MB earlier.
- Core, Geometry (Tensor), Pipelines and Tensor pipelines tutorials are blank.
- There are some Python errors during the sphinx run, starting from:
@ssheorey Found the issue, the methods that I put inside Thanks for catching this. |
…d is enabled." This reverts commit 6696c1b.
@ssheorey Well, the fix is to revert that commit. Running
The README.md mentions |
Type
Motivation and Context
Speeds up building C++ documentation during development of C++ code.
Additionally, printing output path allows quick checking from local system. P.S. Will it be ok to print file uri instead of file path, i.e.
file:///home/sk/workspace/open3d_prs/Open3D/docs/_out/html/index.html
instead of/home/sk/workspace/open3d_prs/Open3D/docs/_out/html/index.html
. The former will be clickable on bash.Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description