Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add podspec to DataSourceKit #8

Merged
merged 3 commits into from
Sep 20, 2018
Merged

Add podspec to DataSourceKit #8

merged 3 commits into from
Sep 20, 2018

Conversation

dehlen
Copy link
Contributor

@dehlen dehlen commented Sep 17, 2018 •
edited
Loading

This way the framework is also usable via CocoaPods.

@dehlen dehlen changed the title add podspec to DataSourceKit Add podspec to DataSourceKit Sep 17, 2018
evermeer
evermeer reviewed Sep 19, 2018
View reviewed changes
DataSourceKit.podspec Outdated
# Not including the public_header_files will make all headers public.
#

s.source_files = "DataSourceKit", "DataSourceKit/**/*.{h,m}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also add swift files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I forgot to edit this.

@ishkawa
Copy link
Owner

ishkawa commented Sep 20, 2018

👍

Thank you for the help!

@ishkawa ishkawa merged commit 8a245c3 into ishkawa:master Sep 20, 2018
@ishkawa
Copy link
Owner

ishkawa commented Sep 20, 2018

Just published on the CocoaPods website 🎉
https://cocoapods.org/pods/DataSourceKit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evermeer evermeer evermeer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dehlen @ishkawa @evermeer