Check rangeCount before getRangeAt(0) #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently on WebKit (including ish's webview), getSelection() can return an object with no ranges (rangeCount == 0). In those cases, calling getRangeAt(0) causes an error to be thrown: "IndexSizeError: The index is not in the allowed range" This error was appearing in the JS console when tapping/clicking randomly. Checking rangeCount here fixes the error. See also: https://stackoverflow.com/questions/22935320/uncaught-indexsizeerror-failed-to-execute-getrangeat-on-selection-0-is-not Signed-off-by: Elvira Khabirova <lineprinter0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently on WebKit (including ish's webview), getSelection() can return an object with no ranges (rangeCount == 0).
In those cases, calling getRangeAt(0) causes an error to be thrown: "IndexSizeError: The index is not in the allowed range"
This error was appearing in the JS console when tapping/clicking randomly. Checking rangeCount here fixes the error.
See also:
https://stackoverflow.com/questions/22935320/uncaught-indexsizeerror-failed-to-execute-getrangeat-on-selection-0-is-not