Merge pull request Azure#1 from Azure/master

merge

.azure-pipelines-preproduction/package.json

@@ -0,0 +1,46 @@
+{
+  "name": "azure-rest-api-specs-tests",
+  "private": true,
+  "author": {
+    "name": "Microsoft Corporation",
+    "email": "azsdkteam@microsoft.com",
+    "url": "https://github.com/azure/azure-rest-api-specs"
+  },
+  "version": "0.1.0",
+  "description": "Tests for Azure REST API Specifications",
+  "license": "MIT",
+  "devDependencies": {
+    "@azure/avocado": "^0.6.2",
+    "@azure/rest-api-specs-scripts": "^0.5.7",
+    "@ts-common/commonmark-to-markdown": "^1.2.0",
+    "@ts-common/fs": "0.2.0",
+    "@ts-common/iterator": "^0.3.6",
+    "@types/js-yaml": "^3.12.1",
+    "@types/mocha": "^5.2.6",
+    "@types/prettier": "^1.18.3",
+    "cspell": "^4.0.30",
+    "js-yaml": "^3.13.1",
+    "json-schema-ref-parser": "^6.1.0",
+    "mocha": "*",
+    "ts-node": "^8.1.0",
+    "tslib": "^1.10.0",
+    "typescript": "3.5.3",
+    "prettier": "^1.18.2"
+  },
+  "homepage": "https://github.com/azure/azure-rest-api-specs",
+  "repository": {
+    "type": "git",
+    "url": "git@github.com:azure/azure-rest-api-specs.git"
+  },
+  "bugs": {
+    "url": "http://github.com/azure/azure-rest-api-specs/issues"
+  },
+  "scripts": {
+    "test": "tsc && mocha -t 500000 --reporter min",
+    "spellcheck": "ts-node ./scripts/spellcheck.ts",
+    "prettier-check": "tsc && ts-node ./scripts/prettier-check.ts",
+    "prettier": "prettier",
+    "tsc": "tsc",
+    "multiapi": "ts-node ./scripts/multiapi.ts"
+  }
+}

.azure-pipelines/Avocado.yml

@@ -0,0 +1,11 @@
+jobs:
+- job: "Avocado"
+  pool:
+    vmImage: 'Ubuntu 16.04'
+  steps:
+  - task: Npm@1
+    displayName: 'npm install'
+    inputs:
+      verbose: false
+  - script: './node_modules/.bin/avocado'
+    displayName: 'Avocado'

.azure-pipelines/BranchProtectionForPrivateRepo.yml

@@ -0,0 +1,8 @@
+jobs:
+  - job: "BranchProtectionForPrivateRepo"
+    pool:
+      vmImage: 'Ubuntu 16.04'
+    condition: and(variables['PRIVATE'], eq(variables['System.PullRequest.TargetBranch'], 'master'))
+    steps:
+    - script: '>&2 echo "the branch is protected"'
+      failOnStderr: true

.azure-pipelines/BreakingChange.yml

@@ -0,0 +1,13 @@
+jobs:
+- job: "BreakingChange"
+  pool:
+    vmImage: 'Ubuntu 16.04'
+  steps:
+  - script: 'scripts/install-dotnet.sh'
+    displayName: 'Install .Net'
+  - task: Npm@1
+    displayName: 'npm install'
+    inputs:
+      verbose: false
+  - script: 'npm run tsc && node scripts/breaking-change.js'
+    displayName: 'Breaking Changes'

.azure-pipelines/LintDiff.yml

@@ -0,0 +1,15 @@
+jobs:
+- job: "LintDiff"
+  variables:
+    NODE_OPTIONS: '--max-old-space-size=8192'
+  pool:
+    vmImage: 'Ubuntu 16.04'
+  steps:
+  - task: Npm@1
+    displayName: 'npm install'
+    inputs:
+      verbose: false
+  - script: 'scripts/install-dotnet.sh'
+    displayName: 'install .Net'
+  - script: 'npm run tsc && node scripts/momentOfTruth.js && node scripts/momentOfTruthPostProcessing.js'
+    displayName: 'LintDiff'

.azure-pipelines/ModelValidation.yml

@@ -0,0 +1,11 @@
+jobs:
+- job: "ModelValidation"
+  pool:
+    vmImage: 'Ubuntu 16.04'
+  steps:
+  - task: Npm@1
+    displayName: 'npm install'
+    inputs:
+      verbose: false
+  - script: 'npm run tsc && node scripts/modelValidation.js'
+    displayName: 'Model Validation'

.azure-pipelines/NetworkValidation.yml

@@ -0,0 +1,39 @@
+jobs:
+- job: "NetworkValidation"
+  condition: and(startsWith(variables['System.PullRequest.TargetBranch'], 'network-'), endsWith(variables['System.PullRequest.TargetBranch'], '-release'))
+  continueOnError: true
+  pool:
+    vmImage: vs2017-win2016
+  variables:
+    NRP_SWAGGER_VALIDATION_OVERRIDE_PS_BRANCH: 'true'
+    NRP_BUILD_TOOLS_SKIP_GENERATE_PS1: 'true'
+    NRP_BUILD_TOOLS_OUTPUT_PATH: '$(System.DefaultWorkingDirectory)\Out'
+  steps:
+  - powershell: |
+      & "C:/Program Files (x86)/Microsoft SDKs/Windows/v10.0A/bin/NETFX 4.6.1 Tools/sn.exe" -Vr *,31bf3856ad364e35
+    displayName: Bypass Strong Name validation
+  - task: NodeTool@0
+    inputs:
+      versionSpec: '10.16.3'
+    displayName: Install Node.js
+  - script: npm install autorest -g
+    displayName: Install autorest
+  - script: git clone --depth 1 -- https://dev.azure.com/v-anevse/BuildScripts/_git/BuildScripts ..\BuildScripts
+    displayName: Clone build tools
+  - powershell: |
+      $swgrPath = (Get-Item ".\").FullName
+      $outputPath = $env:NRP_BUILD_TOOLS_OUTPUT_PATH
+      New-Item -Path $outputPath -ItemType "Directory" -Force | Out-Null
+      ..\BuildScripts\Test-SwaggerRelease.ps1 -Component Network -SwaggerRepoPath $swgrPath -OutputFolder $outputPath
+    failOnStderr: false
+    displayName: Test Swagger updates
+  - powershell: |
+      Copy-Item "..\BuildScripts\.azure-pipelines\.artifactignore" -Destination "$($env:NRP_BUILD_TOOLS_OUTPUT_PATH)\.artifactignore" -Force -ErrorAction "SilentlyContinue"
+    failOnStderr: false
+    condition: always()
+    displayName: Copy .artifactignore
+  - task: PublishPipelineArtifact@0
+    condition: always()
+    inputs:
+      artifactName: SwaggerTestOutput
+      targetPath: $(NRP_BUILD_TOOLS_OUTPUT_PATH)

.azure-pipelines/PrettierCheck.yml

@@ -0,0 +1,15 @@
+jobs:
+- job: "PrettierCheck"
+  condition: "not(variables['PRIVATE'])"
+  variables:
+    NODE_OPTIONS: '--max-old-space-size=8192'
+  pool:
+    vmImage: 'Ubuntu 18.04'
+  continueOnError: true
+  steps:
+  - task: Npm@1
+    displayName: 'npm install'
+    inputs:
+      verbose: false
+  - script: 'npm run prettier-check'
+    displayName: 'Run Prettier Check'

.azure-pipelines/Semantic.yml

@@ -0,0 +1,11 @@
+jobs:
+- job: "Semantic"
+  pool:
+    vmImage: 'Ubuntu 16.04'
+  steps:
+  - task: Npm@1
+    displayName: 'npm install'
+    inputs:
+      verbose: false
+  - script: 'npm run tsc && node scripts/semanticValidation.js'
+    displayName: 'Semantic Validation'

.azure-pipelines/Spellcheck.yml

@@ -0,0 +1,15 @@
+jobs:
+- job: "Spellcheck"
+  condition: "not(variables['PRIVATE'])"
+  variables:
+    NODE_OPTIONS: '--max-old-space-size=8192'
+  pool:
+    vmImage: 'Ubuntu 16.04'
+  continueOnError: true
+  steps:
+  - task: Npm@1
+    displayName: 'npm install'
+    inputs:
+      verbose: false
+  - script: 'npm run spellcheck'
+    displayName: 'Run cSpell'

.azure-pipelines/SwaggerToSDK.yml

@@ -0,0 +1,25 @@
+jobs:
+- job: "SDK"
+  timeoutInMinutes: 180
+  strategy:
+    matrix:
+      java:
+        AZURE_SDK_REPO: azure-sdk-for-java
+        AZURE_SDK_PARAMS: ''
+      javascript:
+        AZURE_SDK_REPO: azure-sdk-for-js
+        AZURE_SDK_PARAMS: ''
+      python:
+        AZURE_SDK_REPO: azure-sdk-for-python
+        AZURE_SDK_PARAMS: ''
+      go:
+        AZURE_SDK_REPO: azure-sdk-for-go
+        AZURE_SDK_PARAMS: '-o latest'
+  pool:
+    vmImage: 'Ubuntu 16.04'
+  variables:
+    NODE_OPTIONS: '--max-old-space-size=8192'
+  steps:
+  - script: echo $(NODE_OPTIONS)
+  - script: "scripts/swagger-to-sdk.sh Azure/$(AZURE_SDK_REPO) -v $(AZURE_SDK_PARAMS)"
+    displayName: "Swagger to SDK script"

.azure-pipelines/Syntax.yml

@@ -0,0 +1,20 @@
+jobs:
+- job: "Syntax"
+  pool:
+    vmImage: 'Ubuntu 16.04'
+  steps:
+  - script: |
+      echo TRAVIS: $(TRAVIS)
+      echo TRAVIS_BRANCH: $(TRAVIS_BRANCH)
+      echo TRAVIS_REPO_SLUG: $(TRAVIS_REPO_SLUG)
+      echo TRAVIS_PULL_REQUEST: $(TRAVIS_PULL_REQUEST)
+      echo TRAVIS_PULL_REQUEST_SLUG: $(TRAVIS_PULL_REQUEST_SLUG)
+      echo TRAVIS_PULL_REQUEST_SHA: $(TRAVIS_PULL_REQUEST_SHA)
+      echo PR_ONLY: $(PR_ONLY)
+    displayName: "Info"
+  - task: Npm@1
+    displayName: 'npm install'
+    inputs:
+      verbose: false
+  - script: 'npm test -- test/syntax.js'
+    displayName: 'Syntax validation'

.github/PULL_REQUEST_TEMPLATE.md

@@ -2,7 +2,7 @@
 <i>MSFT employees can try out our new experience at <b>[OpenAPI Hub](https://aka.ms/openapiportal) </b> - one location for using our validation tools and finding your workflow. 
 </i><br>
 ### Contribution checklist:
-- [ ] I have reviewed the [documentation](https://github.com/Azure/azure-rest-api-specs#basics) for the workflow.
+- [ ] I have reviewed the [documentation](https://github.com/Azure/adx-documentation-pr/wiki/Overall-basic-flow) for the workflow.
 - [ ] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR.
 - [ ] The [OpenAPI Hub](https://aka.ms/openapiportal) was used for checking validation status and next steps.
 ### ARM API Review Checklist

.github/reviewer.yml

@@ -0,0 +1,15 @@
+# This file is openapi-email-bot to store reviewer email address.
+---
+- group:
+    name: default
+    users:
+      - githubID: ruowan
+        email: ruowan@microsoft.com
+      - githubID: raych1
+        email: raychen@microsoft.com
+      - githubID: MyronFanQiu
+        email: fanqiu@microsoft.com
+      - githubID: yungezz
+        email: yungez@microsoft.com
+      - githubID: lirenhe
+        email: Renhe.Li@microsoft.com

.github/sla.yml

@@ -0,0 +1,37 @@
+---
+- scheduleTask:
+    action: sendEmailToAssignee
+    repoWhitelist:
+      - Azure/azure-rest-api-specs
+    args:
+      booleanFilterExpression: "!(WaitForARMFeedback||(DoNotMerge&&(ARMSignedOff||Approved)))"
+      limit: 48h
+      message: '<p> Dear Swagger reviewer, <br> <br> Please response to the PR ${PR_URL}. The PR isn''t updated in 48 hours. <br> <hr /> <br> Quick info. <ul> <li>If no response from ARM review board, please send email to armapireview@microsoft.com.</li> <li>If need immediate ARM review, please get ARM review oncall contact point from ICM https://icm.ad.msft.net/imp/v3/oncall/current under Service "Azure Resource Manager" and Team "RP Manifest Approvers"</li> <li>If no response from Azure API review board, please send email to azureapirbcore@microsoft.com.</li> <li>If you have problem to fix CI task errors, please send email to Visual Studio China Swagger and Tool team vscswagger@microsoft.com.</li> <li>If you want to opt out from Swagger reviewing for out of office period, please set vacation date at https://inframonitorweb1.azurewebsites.net/Home/MyView.</li> <li>Pls refer to <a href="onenote:https://microsoft.sharepoint.com/teams/IoTToolingTeam/SiteAssets/IoT Tooling Team Notebook/Azure Management Experience - transition.one#Swagger%20reviewing%20process§ion-id={ECE847C4-519B-4448-A1A0-8E84A7EFE8AB}&page-id={F6E345FE-46E1-420F-B837-6BF76167DE05}&end">Swagger review process (onenote)</a> for more about Swagger review process.</li> </ul> Best regards, <br> Azure Management Experience </p>'
+      subject: "Action Required: Please respond to PR ${PR_URL}"
+    description: "None initial response in 48 hours. For public repo."
+    name: "[PUBLIC] initial response notification"
+
+- scheduleTask:
+    action: sendEmailToAssignee
+    repoWhitelist:
+      - Azure/azure-rest-api-specs-pr
+    args:
+      booleanFilterExpression: "!(WaitForARMFeedback||Approved-OkToMerge||(DoNotMerge&&(ARMSignedOff||Approved)))"
+      limit: 48h
+      message: '<p> Dear Swagger reviewer, <br> <br> Please response to the PR ${PR_URL}. The PR isn''t updated in 48 hours. <br> <hr /> <br> Quick info. <ul> <li>If no response from ARM review board, please send email to armapireview@microsoft.com.</li> <li>If need immediate ARM review, please get ARM review oncall contact point from ICM https://icm.ad.msft.net/imp/v3/oncall/current under Service "Azure Resource Manager" and Team "RP Manifest Approvers"</li> <li>If no response from Azure API review board, please send email to azureapirbcore@microsoft.com.</li> <li>If you have problem to fix CI task errors, please send email to Visual Studio China Swagger and Tool team vscswagger@microsoft.com.</li> <li>If you want to opt out from Swagger reviewing for out of office period, please set vacation date at https://inframonitorweb1.azurewebsites.net/Home/MyView.</li> <li>Pls refer to <a href="onenote:https://microsoft.sharepoint.com/teams/IoTToolingTeam/SiteAssets/IoT Tooling Team Notebook/Azure Management Experience - transition.one#Swagger%20reviewing%20process§ion-id={ECE847C4-519B-4448-A1A0-8E84A7EFE8AB}&page-id={F6E345FE-46E1-420F-B837-6BF76167DE05}&end">Swagger review process (onenote)</a> for more about Swagger review process.</li> </ul> Best regards, <br> Azure Management Experience </p>'
+      subject: "Action Required: Please respond to PR ${PR_URL}"
+    description: "None initial response in 48 hours. For private repo."
+    name: "[PRIVATE] initial response notification"
+
+- scheduleTask:
+    action: sendEmail
+    repoWhitelist:
+      - Azure/azure-rest-api-specs
+    args:
+      booleanFilterExpression: "(WaitForARMFeedback&&!ARMSignedOff&&!ARMChangesRequested&&!ARMReviewInProgress)"
+      limit: 3d
+      subject: "Action Required: Please help to review PR ${PR_URL}"
+      message: "<p> Dear ARM review board, <br> <br>Please review PR ${PR_URL}, the PR is waiting for ARM review over 3 days. Thanks.<br><hr /> <br>Quick info<ul><li>If you have feedback about the notification email, please contact us at vscswagger@microsoft.com.</li><li>After reviewing, please remove “WaitForARMFeedback” label from PR to avoid receiving notification on the same PR.</li><li>Please do not reply to this email, this is an automatic generated email.</li></ul>Best regards,<br> Azure Management Experience</p>"
+      to: yungez@microsoft.com
+    description: "send email to ARM team for over 5 days PRs labelled with WaitForARMFeedback"
+    name: "send email to ARM team"

.gitignore

@@ -65,7 +65,6 @@ Temporary Items
 
 # npm
 node_modules
-package-lock.json
 
 #### JetBrains
 .idea

.prettierrc.json

@@ -0,0 +1,5 @@
+{
+  "plugins": ["./scripts/prettier-swagger-plugin"],
+  "parser": "json-swagger",
+  "printWidth": 20
+}

.vscode/extensions.json

@@ -1,6 +1,7 @@
 {
-    "recommendations": [
-        "EditorConfig.EditorConfig",
-        "docsmsft.docs-authoring-pack"
-    ]
+  "recommendations": [
+    "EditorConfig.EditorConfig",
+    "esbenp.prettier-vscode",
+    "docsmsft.docs-authoring-pack"
+  ]
 }

.vscode/settings.json

@@ -20,5 +20,8 @@
             "url":"https://raw.githubusercontent.com/Azure/autorest/master/schema/composite-swagger.json"
         }
     ],
-    "typescript.tsdk": "node_modules\\typescript\\lib"
-}
+    "typescript.tsdk": "node_modules\\typescript\\lib",
+    "[json]": {
+        "editor.defaultFormatter": "esbenp.prettier-vscode"
+    }
+}

CODEOWNERS

@@ -10,11 +10,11 @@
 /specification/billing/ @wilcobmsft
 /specification/cdn/ @csmengwan @injyzarif @prakharsharma10
 /specification/cognitiveservices/ @davidlicig @felixwa @yangyuan
-/specification/compute/ @huangpf @hyonholee
+/specification/compute/ @hyonholee @mabhard @danielli90 @smotwani @ppatwa @vikramd-ms @savyasachisamal @yunusm @ZhidongPeng @nkuchta @maheshnemichand @najams @changov
 /specification/consumption/ @kjeur @panda-wang
 /specification/containerinstance/ @samkreter
 /specification/containerregistry/ @djyou
-/specification/containerservice/ @mboersma
+/specification/containerservice/ @yangl900
 /specification/cosmos-db/ @dmakwana
 /specification/customer-insights/ @tjlvtao
 /specification/datafactory/ @zhangyd2015
@@ -43,7 +43,7 @@
 /specification/mobileengagement/ @pshrosbree
 /specification/monitor/ @gucalder
 /specification/mysql/ @qingqingyuan
-/specification/network/ @MikhailTryakhov
+/specification/network/ @MikhailTryakhov @number213
 /specification/notificationhubs/ @amolr @smithab
 /specification/operationalinsights/ @sw47
 /specification/operationsmanagement/ @dashimi16

README.md

@@ -5,10 +5,12 @@
 This repository is the canonical source for REST API specifications for Microsoft Azure.
 
 ## Getting started
-If you're a spec author looking for information about all of the repositories and steps in the pipeline, go to our [documentation](https://github.com/Azure/adx-documentation-pr/wiki) repository. Make sure to [join the Github Azure organization](http://aka.ms/azuregithub) to get access to that repo. 
+If you're a Microsoft employee looking for information about all of the repositories and steps in the pipeline, go to our [documentation](https://github.com/Azure/adx-documentation-pr/wiki) repository. Make sure to [join the Github Azure organization](http://aka.ms/azuregithub) to get access to that repo. 
 
 <b>Latest improvement:</b><i> Microsoft employees can try out our new experience at [OpenAPI Hub](https://aka.ms/openapihub) - online experience for using our validation tools and finding your workflow.</i>
 
+External Contributors can get started [here](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Getting%20started%20with%20OpenAPI%20specifications.md)
+
 Please check the [announcements page](https://github.com/Azure/azure-rest-api-specs/wiki/Announcements) for any new updates since your last visit.
 
 ## Directory Structure
@@ -17,7 +19,7 @@ The structure of the directory should strictly follow these rules:
 
 1. **Profile**: The profile holder contains the profiles' definition MD files. these files will contain information and references to the snapshots of the RPs' Resource types or Dataplane API versions that represent a specific profile.
 
-1. **Specification**: This folder the is root folder for all Specs (Management and Dataplane) related docs.
+1. **Specification**: This folder is the root folder for all Specs (Management and Dataplane) related docs.
 
 1. **{RP-Name} Folders** - each RP will have a separate folder