Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 16, 2023

Bumps actions/labeler from 3.0.0 to 4.0.3.

Release notes

Sourced from actions/labeler's releases.

v4.0.3

What's Changed

  • Make the repo-token input optional. Default is github.token (#227)
  • Bump typescript to 4.9.5 (#496)
  • Bump prettier to 2.8.4 (#498)
  • Bump @​vercel/ncc to 0.36.1 (#493)
  • Bump @​actions/github, minimatch and @​types/minimatch (#477)
  • Update documentation (#278, #285, #476 and #495)

v4.0.2

No release notes provided.

v4.0.1

  • Update @actions/core dependency to v1.9.1 to pull in recent security fixes

v4.0.0

v3.1.0

Dependency upgrades, docs updates, and behind-the-scenes maintenance.

See the full list of changes since 3.0.2 here: actions/labeler@v3.0.2...v3.1.0

Thanks to @​GisoBartels and @​Muhammed-Rahif for their contributions!

v3.0.2

No API changes, but lots of behind-the-scenes upgrades, mostly to internal dependencies, tooling, and surrounding infrastructure.

v3.0.1

No user-facing changes.

That said, there were more than enough behind-the-scenes changes to warrant a new release: actions/labeler@v3.0.0...v3.0.1

Commits
  • ba790c8 feat: default repo-token to github.token (#227)
  • b333851 Merge pull request #498 from actions/dependabot/npm_and_yarn/prettier-2.8.4
  • 7500838 Merge pull request #496 from actions/dependabot/npm_and_yarn/typescript-4.9.5
  • 46f10bd Merge pull request #493 from actions/dependabot/npm_and_yarn/vercel/ncc-0.36.1
  • cfabdea Bump prettier from 2.8.2 to 2.8.4
  • 826c4e6 Bump typescript from 4.9.4 to 4.9.5
  • 8e3e86e Update workflow badges (#495)
  • d4bda4d Bump @​vercel/ncc from 0.36.0 to 0.36.1
  • b435530 Update release-new-action-version.yml (#479)
  • 36adcc2 Update licenses and dependencies (#477)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Mar 16, 2023
Bumps [actions/labeler](https://github.com/actions/labeler) from 3.0.0 to 4.0.3.
- [Release notes](https://github.com/actions/labeler/releases)
- [Commits](actions/labeler@9794b14...ba790c8)

---
updated-dependencies:
- dependency-name: actions/labeler
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot-github_actions-actions-labeler-4.0.3 branch from f1f8ac3 to 2310d49 Compare March 16, 2023 14:55
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 24, 2023

Superseded by #21.

@dependabot dependabot bot closed this May 24, 2023
@dependabot dependabot bot deleted the dependabot-github_actions-actions-labeler-4.0.3 branch May 24, 2023 16:12
isavl pushed a commit that referenced this pull request Jun 3, 2023
Improvement #1:

CapTester.write_test_files() not only creates the test file but also
does the following for every mount object it receives in parameters -

* carefully produces the path for the test file as per parameters
  received
* generates the unique data for each test file on a CephFS mount
* creates a data structure -- list of lists -- that holds all this
  information along with mount object itself for each mount object so
  that tests can be conducted at a later point

Untangle this mess of code by splitting this method into 3 separate
methods -

1. To produce the path for test file (as per user's need).
2. To generate the data that will be written into the test file.
3. To actually create the test file on CephFS.

Improvement #2:

Remove the internal data structure used for testing -- self.test_set --
and use separate class attributes to store all the data required for
testing instead of a tuple. This serves two purpose -

One, it makes it easy to manipulate all this data from helper methods
and during debugging session, especially while using a PDB session.

And two, make it impossible to have multiple mounts/multiple "test sets"
within same CapTester instance for the sake of simplicity. Users can
instead create two instances of CapTester instances if needed.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant