Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctl+Tab/Cmd+Tab should switch bettween opened tabs on editor #80

Open
saint11 opened this issue May 11, 2024 · 2 comments
Open

Ctl+Tab/Cmd+Tab should switch bettween opened tabs on editor #80

saint11 opened this issue May 11, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@saint11
Copy link
Collaborator

saint11 commented May 11, 2024

The problem most likely lies in EditorScene.cs, there's something about ImGui that we are misunderstanding that's causing a weird behaviour when trying to cycle through tabs.

Basically we need it to cycle only the _selectedTab to the windows opened on _selectedAssets.

@saint11 saint11 added bug Something isn't working good first issue Good for newcomers labels May 11, 2024
@MarcinKuder
Copy link
Contributor

MarcinKuder commented May 31, 2024

I've noticed that commenting out "ImGui.SetNextWindowFocus()" in EditorScene_Editors.cs (line 76) makes tab switching better. It's not perfect - at the end of cycle it switches focus to the main menu but it is still better than with the line present.
Not sure what are the side effects.

@saint11
Copy link
Collaborator Author

saint11 commented Jun 23, 2024

Got it working much better on b9dfdb4, not 100% though. I still can't figure out how to remove the main menu bar from the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants