rimraf node_modules delete all files

[xiaoxue1341]

I have a monorepo warehouse. When I delete node at the outermost layer_ Modules folder, the files in each folder under packages are also deleted

[isaacs]

That definitely shouldn't happen. What command are you running?

[edw1882]

Something like this I suspect

rimraf --glob node_modules */node_modules

It removes the contents of the folders that contain a node_modules folder as well

[isaacs]

Yeah, but have you tested that? Because that is not what I'm seeing.

#!/bin/bash

rm -rf test-gh-259
mkdir test-gh-259
cd test-gh-259
mkdir -p node_modules/{a,b,c}
touch node_modules/{a,b,c}/{index.js,package.json}
mkdir -p packages/{x,y,z}/node_modules/{i,j,k}
touch packages/{x,y,z}/{node_modules/{i,j,k}/,}{index.js,package.json}
ln -s ../packages/x node_modules/x
ln -s ../packages/y node_modules/y
ln -s ../packages/z node_modules/z
ln -s ../x packages/y/node_modules/x
ln -s ../x packages/z/node_modules/x
ln -s ../y packages/x/node_modules/y
ln -s ../y packages/z/node_modules/y
ln -s ../z packages/x/node_modules/z
ln -s ../z packages/y/node_modules/z

tree
npx -y rimraf@latest --glob "node_modules" "packages/*/node_modules"
tree

Output:

.
├── node_modules
│   ├── a
│   │   ├── index.js
│   │   └── package.json
│   ├── b
│   │   ├── index.js
│   │   └── package.json
│   ├── c
│   │   ├── index.js
│   │   └── package.json
│   ├── x -> ../packages/x
│   ├── y -> ../packages/y
│   └── z -> ../packages/z
└── packages
    ├── x
    │   ├── index.js
    │   ├── node_modules
    │   │   ├── i
    │   │   │   ├── index.js
    │   │   │   └── package.json
    │   │   ├── j
    │   │   │   ├── index.js
    │   │   │   └── package.json
    │   │   ├── k
    │   │   │   ├── index.js
    │   │   │   └── package.json
    │   │   ├── y -> ../y
    │   │   └── z -> ../z
    │   └── package.json
    ├── y
    │   ├── index.js
    │   ├── node_modules
    │   │   ├── i
    │   │   │   ├── index.js
    │   │   │   └── package.json
    │   │   ├── j
    │   │   │   ├── index.js
    │   │   │   └── package.json
    │   │   ├── k
    │   │   │   ├── index.js
    │   │   │   └── package.json
    │   │   ├── x -> ../x
    │   │   └── z -> ../z
    │   └── package.json
    └── z
        ├── index.js
        ├── node_modules
        │   ├── i
        │   │   ├── index.js
        │   │   └── package.json
        │   ├── j
        │   │   ├── index.js
        │   │   └── package.json
        │   ├── k
        │   │   ├── index.js
        │   │   └── package.json
        │   ├── x -> ../x
        │   └── y -> ../y
        └── package.json

23 directories, 36 files
.
└── packages
    ├── x
    │   ├── index.js
    │   └── package.json
    ├── y
    │   ├── index.js
    │   └── package.json
    └── z
        ├── index.js
        └── package.json

4 directories, 6 files

[isaacs]

It's just deleting the node_modules folders, not the package contents themselves.

[isaacs]

Replacing the rimraf command with npx -y rimraf@latest --glob '**/node_modules' has the same effect. Removes node_modules, not the package source contents.

[isaacs]

Will re-open if reproduction case is provided.

[xiaoxue1341]

ypLive-Visual-Studio-Code-2023-0.mp4

You can see this video. All the files in liveRoom2 have been deleted. The file change area on the left shows the deleted 3k+files

[isaacs]

The video is not loading. Please share what command you ran. Just comment as text, not a video or screenshot.

[edw1882]

He's on windows and running

rimraf node_modules

It is deleting ALL the files in a folder further down the tree that happens to have a node_modules folder.

[isaacs]

Ah, I think I see what's going on. Symlinks aren't being handled properly in the windows version. Will fix shortly.

[isaacs]

Fixed on 4.3.1. It could also have affected posix systems, so this is potentially serious. Thanks for reporting it.