Wait longer for rename lock contention to resolve #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
requested changes
Oct 26, 2016
| fs$rename(from, to, CB); | ||
| }, backoff) | ||
| if (backoff < 100) | ||
| backoff += 10; |
There was a problem hiding this comment.
Shouldn't there be a return here? Otherwise it'll call the callback on every iteration of the retry.
There was a problem hiding this comment.
Yes, I'm sorry. @aldenchan, take notice of above, I pushed a fixup.
Anti-virus software on Windows can lock files for long periods of time, and graceful-fs was only waiting up to a second, and busy-looping during that wait, which has the potential to starve the locker of CPU.
|
Thank you, @isaacs |
|
Any idea what the timeline is for this to be available via npm? |
othiym23
added a commit
to npm/npm
that referenced
this pull request
Nov 4, 2016
Better backoff for EPERM on Windows. Credit: @sam-github Fixes: #12059 Reviewed-By: @othiym23 Reviewed-By: @isaacs PR-URL: isaacs/node-graceful-fs#97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anti-virus software on Windows can lock files for long periods of time,
and graceful-fs was only waiting up to a second, and busy-looping during
that wait, which has the potential to starve the locker of CPU.
Fixes npm/npm#12059