Skip to content

Improve question finder logging and search results #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2025

Conversation

jsharkey13
Copy link
Member

See the three individual commits for details:

  • don't show superseded/nofilter questions on random question searches;
  • don't log details about random question searches;
  • improve title and subtitle matching when searching questions.

We don't need to log a user getting a random question for a landing
page, we are interested in intentional searches.
siteWideSearch() uses FUZZY matching for all fields. Not sure if that
is best here, but using it for title and subtitle gives better results.
@jsharkey13
Copy link
Member Author

jsharkey13 commented Jun 17, 2025

The test is failing because the assignment test object better matches the "Regression Test Page" search than the page with that title. This is unfortunate, because generally the fuzzy match provides better results for title searches than the substring matching did 😣

EDIT: Further testing suggests the gain isn't universal, and in some cases this new one is worse. We're reverting for now, and will come back to this particular improvement another time.

This reverts commit f74aac7.

This is causing test failures, and further testing seems to show that
whilst it is better in some cases it is not a quick fix. We'll come back
to this.
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.79%. Comparing base (2146f4c) to head (657c164).

Files with missing lines Patch % Lines
...n/java/uk/ac/cam/cl/dtg/isaac/api/PagesFacade.java 86.95% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #701   +/-   ##
=======================================
  Coverage   35.79%   35.79%           
=======================================
  Files         535      535           
  Lines       23598    23602    +4     
  Branches     2859     2860    +1     
=======================================
+ Hits         8446     8449    +3     
  Misses      14288    14288           
- Partials      864      865    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwtrew mwtrew merged commit 5d7feae into master Jun 19, 2025
5 checks passed
@mwtrew mwtrew deleted the redesign/question-finder-fixes branch June 19, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants