Allow valid permutations of molecules in api #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #639 +/- ##
=========================================
Coverage ? 34.08%
=========================================
Files ? 520
Lines ? 23294
Branches ? 2853
=========================================
Hits ? 7939
Misses ? 14554
Partials ? 801 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/uk/ac/cam/cl/dtg/isaac/quiz/IsaacSymbolicChemistryValidator.java
Fixed
Show resolved
Hide resolved
jsharkey13
reviewed
Sep 24, 2024
src/main/java/uk/ac/cam/cl/dtg/isaac/dos/IsaacSymbolicChemistryQuestion.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/ac/cam/cl/dtg/isaac/dto/IsaacSymbolicChemistryQuestionDTO.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/ac/cam/cl/dtg/isaac/quiz/IsaacSymbolicChemistryValidator.java
Outdated
Show resolved
Hide resolved
Co-authored-by: James Sharkey <jsharkey13@users.noreply.github.com>
Turns out those annotations were necessary, because these getters didn't use the conventional (but not nice here) format :sigh:
jsharkey13
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes the
allowPermutationsflag from the Content Editor to the Chemistry CheckerCompanion PR to Allow valid permutations of molecules for the Chemistry Checker.