Skip to content

Commit 05c22be

Browse files
authored
Removes protobuf upper version pin (#2726)
# Description This PR relaxes the upper range of allowed protobuf versions so that IsaacLab can be installed in a modern python environment without downgrading or conflicting with modern protobuf versions. The original reason for pinning this to <5 was apparently due to transitive breakage in tensorboard, which also had this pinned to <5 - so pinning this in IsaacLab itself would not be necessary if both deps were composed together. Tensorboard has since (in Aug 2024) unpinned this here: tensorflow/tensorboard#6888 So, the original concern should, afaict, be obviated now. # Fixes This should repair any case where someone wants to install IsaacLab into a modern python environment that uses any of the Google ecosystem (gRPC/protobuf et al) without conflict or forced down-rev'ing to older versions (current version of protobuf is 6.31.1). ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
1 parent 394a162 commit 05c22be

File tree

7 files changed

+23
-9
lines changed

7 files changed

+23
-9
lines changed

CONTRIBUTORS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ Guidelines for modifications:
7575
* Jinqi Wei
7676
* Johnson Sun
7777
* Kaixi Bao
78+
* Kris Wilson
7879
* Kourosh Darvish
7980
* Kousheek Chakraborty
8081
* Lionel Gulich

source/isaaclab_rl/config/extension.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[package]
22

33
# Note: Semantic Versioning is used: https://semver.org/
4-
version = "0.1.5"
4+
version = "0.1.6"
55

66
# Description
77
title = "Isaac Lab RL"

source/isaaclab_rl/docs/CHANGELOG.rst

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
Changelog
22
---------
33

4+
0.1.6 (2025-06-26)
5+
~~~~~~~~~~~~~~~~~~
6+
7+
Fixed
8+
^^^^^
9+
10+
* Relaxed upper range pin for protobuf python dependency for more permissive installation.
11+
12+
413
0.1.5 (2025-04-11)
514
~~~~~~~~~~~~~~~~~~
615

@@ -9,7 +18,6 @@ Changed
918
* Optimized Stable-Baselines3 wrapper ``Sb3VecEnvWrapper`` (now 4x faster) by using Numpy buffers and only logging episode and truncation information by default.
1019
* Upgraded minimum SB3 version to 2.6.0 and added optional dependencies for progress bar
1120

12-
1321
0.1.4 (2025-04-10)
1422
~~~~~~~~~~~~~~~~~~
1523

source/isaaclab_rl/setup.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@
2222
"numpy",
2323
"torch==2.5.1",
2424
"torchvision>=0.14.1", # ensure compatibility with torch 1.13.1
25-
# 5.26.0 introduced a breaking change, so we restricted it for now.
26-
# See issue https://github.com/tensorflow/tensorboard/issues/6808 for details.
27-
"protobuf>=3.20.2, < 5.0.0",
25+
"protobuf>=3.20.2,!=5.26.0",
2826
# configuration management
2927
"hydra-core",
3028
# data collection

source/isaaclab_tasks/config/extension.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[package]
22

33
# Note: Semantic Versioning is used: https://semver.org/
4-
version = "0.10.35"
4+
version = "0.10.36"
55

66
# Description
77
title = "Isaac Lab Environments"

source/isaaclab_tasks/docs/CHANGELOG.rst

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
Changelog
22
---------
33

4+
0.10.36 (2025-06-26)
5+
~~~~~~~~~~~~~~~~~~~~
6+
7+
Fixed
8+
^^^^^
9+
10+
* Relaxed upper range pin for protobuf python dependency for more permissive installation.
11+
12+
413
0.10.35 (2025-05-22)
514
~~~~~~~~~~~~~~~~~~~~
615

source/isaaclab_tasks/setup.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@
2121
"numpy",
2222
"torch==2.5.1",
2323
"torchvision>=0.14.1", # ensure compatibility with torch 1.13.1
24-
# 5.26.0 introduced a breaking change, so we restricted it for now.
25-
# See issue https://github.com/tensorflow/tensorboard/issues/6808 for details.
26-
"protobuf>=3.20.2, < 5.0.0",
24+
"protobuf>=3.20.2,!=5.26.0",
2725
# basic logger
2826
"tensorboard",
2927
# automate

0 commit comments

Comments
 (0)