-
-
Notifications
You must be signed in to change notification settings - Fork 50
Global Search #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: multiversion/dev
Are you sure you want to change the base?
Global Search #278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this! Thank you for the contribution.
I think it best not to clutter the interface even more with a toggle. It makes sense that a search box should search everything, not just the current tab. One suggestion though, might be a bit tricky. Because entering in a non-matching search will change tabs automatically, the current tab should always prefer to be the originally selected tab if any results come up. |
ce2564b
to
81f9e9b
Compare
I think I managed to do that |
|
||
@Override | ||
public boolean mouseClicked(double mouseX, double mouseY, int button /*? if >=1.21.9 {*/ ,boolean doubleClick /*?}*/) { | ||
preferredTab = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means keyboard and controller navigation will not update this. You aught to find a better place for this to go in order to be a bit more abstract about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah right
um
maybe in setFocused
?
Grays out tabs where the result isn't and moves you automatically to the next tab.
Not sure if this is an implementation you like.
Someone suggested to add a toggle for the global search above the search bar or something, tell me if you think it's a good idea.