Bugfix: Add PSPC platform type #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you omz1990 hopefully a fix, a script I run to record my friends trophy progress broke earlier today due to the unsupported platform type PSPC. Agree something more robust needed to fall back on for unknown platform type. |
|
What platform is PSPC? PlayStation PC? |
Yes, PC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library crashing for trophy titles after new platform type added by PSN API. This pull request fixes the bug for the time being, but maybe the library should have a fallback such that it falls back to
UNKNOWNinstead of crashing in case a new platform is added in the future.