Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: incorrect play time parsing #60

Merged

Conversation

omz1990
Copy link
Contributor

@omz1990 omz1990 commented Jan 21, 2024

Bugfix: Incorrect play time parsing

  • Previous implementation didn't account for a scenario where there were only Hours and Seconds in the input string which led this input: PT18H20S to be parsed as 18 minutes 20 seconds.
  • PT18H20S is a valid response coming from the PSN API.

This function now produces the following time delta based on the provided inputs:
Screenshot 2024-01-21 at 6 29 52 pm

@isFakeAccount isFakeAccount merged commit fd5bd34 into isFakeAccount:master Jan 21, 2024
1 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants