Skip to content

fix multiple instnace prefix issue #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix multiple instnace prefix issue #4

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d0900d
fix multiple instnace prefix issue
Jan 14, 2017
3378e39
using better const name
Jan 14, 2017
07584cc
using better const name
Jan 14, 2017
b6ee94c
fix comment
Jan 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
const _REDUX_COOKIES_GET = 'REDUX_COOKIES_GET';

let REDUX_COOKIES_GET = 'REDUX_COOKIES_GET';
let REDUX_COOKIES_SET = 'REDUX_COOKIES_SET';
let REDUX_COOKIES_EXPIRE = 'REDUX_COOKIES_EXPIRE';
let REDUX_COOKIES_REMOVE = 'REDUX_COOKIES_REMOVE';

export const getName = (prefix, itemName) => prefix + itemName;
export const getName = (prefix, itemName) => `${prefix}${itemName}`;

export const getCookie = name => {
return { type: REDUX_COOKIES_GET, name };
Expand All @@ -24,10 +26,15 @@ export const removeCookie = (name, options) => {
export const createCookieMiddleware = (cookies, prefix = '') => {
const actionsMap = {};

REDUX_COOKIES_GET = getName(prefix, REDUX_COOKIES_GET);
REDUX_COOKIES_SET = getName(prefix, REDUX_COOKIES_SET);
REDUX_COOKIES_EXPIRE = getName(prefix, REDUX_COOKIES_EXPIRE);
REDUX_COOKIES_REMOVE = getName(prefix, REDUX_COOKIES_REMOVE);
// It is to check if it has prefixed
// You can only prefix once, subsequent prefix will be ignored
// https://github.com/iroy2000/redux-cookie/issues/3
if(_REDUX_COOKIES_GET === REDUX_COOKIES_GET) {
REDUX_COOKIES_GET = getName(prefix, REDUX_COOKIES_GET);
REDUX_COOKIES_SET = getName(prefix, REDUX_COOKIES_SET);
REDUX_COOKIES_EXPIRE = getName(prefix, REDUX_COOKIES_EXPIRE);
REDUX_COOKIES_REMOVE = getName(prefix, REDUX_COOKIES_REMOVE);
}

actionsMap[REDUX_COOKIES_GET] = action => {
try {
Expand Down