[PROVIDER-2289] fix terminals/status endpoint losing status data when pagination disabled #2997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ironArt3mis
changed the title
danigargar
requested changes
Aug 13, 2025
R0MANDEV
force-pushed
the
PROVIDER-2289-fix-terminals-status-pagination-context
branch
3 times, most recently
from
c417bb1 to
8efb00d
Compare
danigargar
requested changes
Aug 14, 2025
web/rest/brand/features/provider/terminal/getTerminalStatus.feature
Outdated
Show resolved
Hide resolved
R0MANDEV
force-pushed
the
PROVIDER-2289-fix-terminals-status-pagination-context
branch
2 times, most recently
from
d41e745 to
2f2c96c
Compare
R0MANDEV
force-pushed
the
PROVIDER-2289-fix-terminals-status-pagination-context
branch
from
2f2c96c to
e1b8868
Compare
danigargar
requested changes
Sep 17, 2025
There was a problem hiding this comment.
Overriding the default controller has side effects. What happens with filters?
Moreover: what happens with pagination itself?
if you pass _itemsPerPage=1, how many items does this return?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atus endpoint
Type Of Change
Checklist:
Description
Additional information