BCN 04/19 - Yvonne Moser #6
Conversation
| <img src="./images/oracle-logo.png" alt=""> | ||
| <img src="./images/ticketmaster-logo.png" alt=""> | ||
| <button class="white-button">DISCOVER WHY</button> | ||
| <img class="logo-img" src="./images/airbnb-logo.png" alt=""> |
There was a problem hiding this comment.
Now that you have changed them you could've added the alt attribute content :)
| @@ -1,7 +1,258 @@ | |||
| html, body, div, span, applet, object, iframe, | |||
|
|
||
|
|
||
|
|
||
| @media screen and (max-width: 768px){ |
There was a problem hiding this comment.
You don't need to put all your code inside this @mediaquery. Just specific things that only are different for that screen size. Please if you have questions regarding how to use media queries let us know.
| align-items: center; | ||
| width: 100%; | ||
| } | ||
|
|
There was a problem hiding this comment.
Try to be consistent with the format, if you add a blank space between rules always keep it with one and not two
| header { | ||
| display: flex; | ||
| flex-direction: column; | ||
| margin-top: 100px; /*how can i put it to the next position without using margin? with flex column?*/ |
There was a problem hiding this comment.
If the previous element have position: fixed you need the margin to separe them.
| color: #2C303F; | ||
| font-size: 35px; | ||
| font-weight: bold; | ||
| margin: 0 15px 15px 15px; |
There was a problem hiding this comment.
Try to find the way no to repeat code in CSS neither. So in this case margin: 0 15px 15px 15px; is the same in the h1 and p, maybe you could find a way to put it in both with one rule?
| } | ||
|
|
||
| footer { | ||
| display: flex; |
|
|
||
| #footerI { | ||
| display: flex; | ||
| flex-direction: row; |
There was a problem hiding this comment.
by default flex-direction is row
2 participants
No description provided.