BCN Web Dev 04/2019 - Dino #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tawebbcn
reviewed
Apr 8, 2019
| max-width: 100%; | ||
| } | ||
|
|
||
| @media (max-width: 768px) { |
There was a problem hiding this comment.
You don't need to put all your code inside this @Mediaquery. Just specific things that only are different for that screen size. Please if you have questions regarding how to use media queries let us know.
tawebbcn
reviewed
Apr 8, 2019
| .ul-parent { | ||
| /* margin-right: 10px; */ | ||
| display: flex; | ||
| flex-direction: row; |
There was a problem hiding this comment.
the default value for flex-direction is already row.
tawebbcn
reviewed
Apr 8, 2019
| <meta http-equiv="X-UA-Compatible" content="ie=edge"> | ||
| <script src="https://use.fontawesome.com/1fb0eb3889.js"></script> | ||
| <link href="https://fonts.googleapis.com/css?family=Heebo:400,700" rel="stylesheet"> | ||
| <!-- <link rel="stylesheet" type="text/css" href="./stylesheets/reset.css"> --> |
There was a problem hiding this comment.
you commented out the reset file so the reset isn't taking place.
tawebbcn
reviewed
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.