Skip to content

anthony-bruscantini #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

bruscantini
Copy link

No description provided.

@@ -1,14 +1,28 @@
// Find the maximum
function maxOfTwoNumbers (first, second) {

if (first > second) return first;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!!

Also, you could consider this:

return (first > second ? first : second);

@f3r f3r closed this Aug 29, 2017
ericksicard added a commit to ericksicard/Ironhack-lab-javascript-functions-and-arrays that referenced this pull request Oct 29, 2019
ericksicard added a commit to ericksicard/Ironhack-lab-javascript-functions-and-arrays that referenced this pull request Oct 29, 2019
javivarelakdi pushed a commit to javivarelakdi/lab-javascript-functions-and-arrays that referenced this pull request Dec 27, 2019
jaimemorav added a commit to jaimemorav/lab-javascript-functions-and-arrays that referenced this pull request Jan 6, 2020
jaimemorav added a commit to jaimemorav/lab-javascript-functions-and-arrays that referenced this pull request Jan 6, 2020
caioandreolli added a commit to caioandreolli/lab-javascript-functions-and-arrays that referenced this pull request Jan 25, 2020
fabioMatosCosta added a commit to fabioMatosCosta/lab-javascript-functions-and-arrays that referenced this pull request Feb 19, 2020
GabrielBohn99 added a commit to GabrielBohn99/lab-javascript-functions-and-arrays that referenced this pull request Feb 21, 2020
@phpaul89 phpaul89 mentioned this pull request Mar 25, 2020
@skanndar skanndar mentioned this pull request Apr 1, 2020
JohannaXX added a commit to JohannaXX/lab-javascript-functions-and-arrays that referenced this pull request May 3, 2020
Pumpelgit added a commit to Pumpelgit/lab-javascript-functions-and-arrays that referenced this pull request May 4, 2020
Pumpelgit added a commit to Pumpelgit/lab-javascript-functions-and-arrays that referenced this pull request May 4, 2020
Pumpelgit added a commit to Pumpelgit/lab-javascript-functions-and-arrays that referenced this pull request May 5, 2020
AmanoLX added a commit to AmanoLX/lab-javascript-functions-and-arrays that referenced this pull request Jun 6, 2020
giladt added a commit to giladt/lab-javascript-functions-and-arrays that referenced this pull request Aug 11, 2020
giladt added a commit to giladt/lab-javascript-functions-and-arrays that referenced this pull request Aug 11, 2020
mixed-salad added a commit to mixed-salad/lab-javascript-functions-and-arrays that referenced this pull request Oct 30, 2020
luisga32 added a commit to luisga32/lab-javascript-functions-and-arrays that referenced this pull request Nov 20, 2020
Praa199 added a commit to Praa199/lab-javascript-functions-and-arrays that referenced this pull request Jan 13, 2021
Praa199 added a commit to Praa199/lab-javascript-functions-and-arrays that referenced this pull request Jan 13, 2021
John-v77 added a commit to John-v77/lab-javascript-functions-and-arrays that referenced this pull request Jan 14, 2021
leoopardo added a commit to leoopardo/lab-javascript-functions-and-arrays that referenced this pull request Mar 22, 2022
leoopardo added a commit to leoopardo/lab-javascript-functions-and-arrays that referenced this pull request Mar 23, 2022
@fevi-ro fevi-ro mentioned this pull request Mar 29, 2022
wijaman23 pushed a commit to wijaman23/lab-javascript-functions-and-arrays that referenced this pull request Apr 30, 2022
AlmuVera added a commit to AlmuVera/lab-javascript-functions-and-arrays that referenced this pull request May 2, 2022
LuisEUM added a commit to LuisEUM/lab-javascript-functions-and-arrays that referenced this pull request May 3, 2022
LuisEUM added a commit to LuisEUM/lab-javascript-functions-and-arrays that referenced this pull request May 3, 2022
elorenn added a commit to elorenn/lab-javascript-functions-and-arrays that referenced this pull request Jun 9, 2022
renatainojosa added a commit to renatainojosa/lab-javascript-functions-and-arrays that referenced this pull request Jun 22, 2022
renatainojosa added a commit to renatainojosa/lab-javascript-functions-and-arrays that referenced this pull request Jun 22, 2022
droidsam1 added a commit to droidsam1/lab-javascript-functions-and-arrays that referenced this pull request Jun 26, 2022
droidsam1 added a commit to droidsam1/lab-javascript-functions-and-arrays that referenced this pull request Jun 26, 2022
droidsam1 added a commit to droidsam1/lab-javascript-functions-and-arrays that referenced this pull request Jun 26, 2022
superpensando added a commit to superpensando/lab-javascript-functions-and-arrays that referenced this pull request Jun 28, 2022
asantamar87 added a commit to asantamar87/lab-javascript-functions-and-arrays that referenced this pull request Nov 16, 2022
physiodevapp added a commit to physiodevapp/lab-javascript-functions-and-arrays that referenced this pull request Nov 16, 2022
fraulueneburg-ironhack added a commit to fraulueneburg-ironhack/lab-javascript-functions-and-arrays that referenced this pull request Feb 12, 2023
KseniiaErnest added a commit to KseniiaErnest/lab-javascript-functions-and-arrays that referenced this pull request Mar 20, 2023
KseniiaErnest added a commit to KseniiaErnest/lab-javascript-functions-and-arrays that referenced this pull request Mar 21, 2023
gunnar-miklis added a commit to gunnar-miklis/lab-javascript-functions-and-arrays that referenced this pull request Mar 23, 2023
gunnar-miklis added a commit to gunnar-miklis/lab-javascript-functions-and-arrays that referenced this pull request Mar 23, 2023
@HeimLi HeimLi mentioned this pull request Mar 28, 2023
ProgrammingDj added a commit to ProgrammingDj/lab-javascript-functions-and-arrays that referenced this pull request May 11, 2023
AlfG71 added a commit to AlfG71/lab-javascript-functions-and-arrays that referenced this pull request Aug 31, 2023
AlfG71 added a commit to AlfG71/lab-javascript-functions-and-arrays that referenced this pull request Aug 31, 2023
SunSunny1210 added a commit to SunSunny1210/lab-javascript-functions-and-arrays that referenced this pull request Feb 17, 2025
SunSunny1210 added a commit to SunSunny1210/lab-javascript-functions-and-arrays that referenced this pull request Feb 17, 2025
SunSunny1210 added a commit to SunSunny1210/lab-javascript-functions-and-arrays that referenced this pull request Feb 17, 2025
SunSunny1210 added a commit to SunSunny1210/lab-javascript-functions-and-arrays that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants