-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[PTREMOTE] - Ana Pais #3843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anabalf
wants to merge
5
commits into
ironhack-labs:master
Choose a base branch
from
anabalf:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[PTREMOTE] - Ana Pais #3843
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,38 +1,75 @@ | ||
// Iteration #1: Find the maximum | ||
function maxOfTwoNumbers() {} | ||
|
||
|
||
function maxOfTwoNumbers(n1, n2) { | ||
if (n1 > n2) { | ||
return n1; | ||
} else { | ||
return n2; | ||
} | ||
} | ||
|
||
// Iteration #2: Find longest word | ||
const words = ['mystery', 'brother', 'aviator', 'crocodile', 'pearl', 'orchard', 'crackpot']; | ||
|
||
function findLongestWord() {} | ||
function findLongestWord(words) { | ||
if(words.length === 0) { | ||
return null; | ||
} | ||
let longestWord; | ||
for (let i = 0; i < words.length; i++) { | ||
if (!longestWord || words[i].length > longestWord.length) { | ||
longestWord = words[i] | ||
} | ||
} | ||
return longestWord | ||
} | ||
|
||
|
||
|
||
// Iteration #3: Calculate the sum | ||
const numbers = [6, 12, 1, 18, 13, 16, 2, 1, 8, 10]; | ||
|
||
function sumNumbers() {} | ||
function sumNumbers(numbers) { | ||
let sum = 0; | ||
for (let i = 0; i < numbers.length; i++) { | ||
sum += numbers[i]; | ||
} | ||
return sum; | ||
} | ||
|
||
|
||
|
||
// Iteration #3.1 Bonus: | ||
function sum() {} | ||
function sum(numbers) { | ||
} | ||
|
||
|
||
|
||
// Iteration #4: Calculate the average | ||
// Level 1: Array of numbers | ||
const numbersAvg = [2, 6, 9, 10, 7, 4, 1, 9]; | ||
|
||
function averageNumbers() {} | ||
function averageNumbers(numbersAvg) { | ||
if(numbersAvg.length === 0) { | ||
return null; | ||
} | ||
let sum = sumNumbers(numbersAvg); | ||
let count = numbersAvg.length; | ||
return sum/count; | ||
} | ||
|
||
|
||
// Level 2: Array of strings | ||
const wordsArr = ['seat', 'correspond', 'linen', 'motif', 'hole', 'smell', 'smart', 'chaos', 'fuel', 'palace']; | ||
|
||
function averageWordLength() { } | ||
function averageWordLength(wordsArr) { | ||
if(wordsArr.length === 0) { | ||
return null; | ||
} | ||
let sum = wordsArr.join('').length; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔥 Excelente forma de resolverlo |
||
let count = wordsArr.length; | ||
return sum/count; | ||
} | ||
|
||
|
||
// Bonus - Iteration #4.1 | ||
function avg() {} | ||
|
@@ -52,14 +89,37 @@ const wordsUnique = [ | |
'bring' | ||
]; | ||
|
||
function uniquifyArray() {} | ||
function uniquifyArray(wordsUnique) { | ||
if(wordsUnique.length === 0) { | ||
return null; | ||
} | ||
let uniqueWords = []; | ||
for (let i = 0; i < wordsUnique.length; i++) { | ||
const currentWord = wordsUnique[i]; //crab | ||
if (!uniqueWords.includes(currentWord)) { | ||
uniqueWords.push(currentWord) | ||
} | ||
} | ||
return uniqueWords | ||
} | ||
|
||
|
||
|
||
// Iteration #6: Find elements | ||
const wordsFind = ['machine', 'subset', 'trouble', 'starting', 'matter', 'eating', 'truth', 'disobedience']; | ||
|
||
function doesWordExist() {} | ||
function doesWordExist(wordsFind, word) { | ||
if(wordsFind.length === 0) { | ||
return null; | ||
} | ||
let exists = false | ||
for(let i = 0; i < wordsFind.length; i++) { | ||
if(word === wordsFind[i]){ | ||
exists =true | ||
} | ||
} | ||
return exists; | ||
} | ||
|
||
|
||
|
||
|
@@ -78,7 +138,15 @@ const wordsCount = [ | |
'matter' | ||
]; | ||
|
||
function howManyTimes() {} | ||
function howManyTimes(wordsCount, word) { | ||
let count = 0; | ||
for (let i = 0; i < wordsCount.length; i++) { | ||
if(word === wordsCount[i]){ | ||
count++; | ||
} | ||
} | ||
return count | ||
} | ||
|
||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lo que podemos hacer aqui para remover ese !longestWord es inicializar la palabra como un string vacio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asi podemos remover la priemra ocndicion del if y funcionaria sin problema :D