Skip to content

Review PR #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 27, 2021
Merged

Review PR #2379

merged 3 commits into from
May 27, 2021

Conversation

ross-u
Copy link
Contributor

@ross-u ross-u commented May 27, 2021

  • Rephrased instructions to remove the notion of declaring functions, as they are already declared.
  • Updated the src/functions-and-arrays.js to add missing function declaration and export the same.
  • Updated the tests imports to add missing function declaration.

@ross-u ross-u requested a review from sandrabosk May 27, 2021 20:27
@ironhack-edu ironhack-edu merged commit df8f8b0 into master May 27, 2021
@ironhack-edu ironhack-edu deleted the uros/review branch May 31, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandrabosk sandrabosk Awaiting requested review from sandrabosk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ross-u @ironhack-edu