Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dw 30 optimize extract alpha data and prepare byte array #125

Merged

Conversation

ikkyuland
Copy link
Member

@ikkyuland ikkyuland commented Feb 20, 2025

Title

slightly improve speed of ExtractAlphaData and PrepareByteArray

Description

  • use array and index to increase speed of ExtractAlphaData
  • use BlockCopy to increase speed PrepareByteArray

Fixes
DW-30

Type of change

Please select the relevant option by placing an 'x' inside the brackets, like this: [x].

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🏗️ Internal/structural update (non-breaking change that improves code quality, organization, or performance)
  • 📚 This change requires a documentation update
  • 🚀 DevOps build chain modification for release
  • 🤖 DevOps build chain modification for CI

How Has This Been Tested?

all test passes,
ExtractAlphaData-compare

Checklist:

Please run through the checklist as much as possible and mark the items completed by placing an 'x' inside the brackets, like this: [x].

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully run all unit tests on Windows
  • I have successfully run all unit tests on Linux

Additional Context

Add any other context, screenshots, or information about the pull request here.

@djrecipe djrecipe force-pushed the DW-30-optimize-ExtractAlphaData-and-PrepareByteArray branch from 58e2bc1 to 3872ae2 Compare February 21, 2025 07:21
@djrecipe djrecipe merged commit ddff78b into develop Feb 21, 2025
1 check passed
@djrecipe djrecipe deleted the DW-30-optimize-ExtractAlphaData-and-PrepareByteArray branch February 21, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants