Fix lambda import #605
Merged
Fix lambda import #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treeder
suggested changes
Mar 23, 2017
fn/lambda.go
Outdated
| @@ -214,9 +110,13 @@ func awsImport(c *cli.Context) error { | |||
| return err | |||
| } | |||
|
|
|||
| if *function.Configuration.Runtime == "nodejs4.3" { | |||
| *function.Configuration.Runtime = "node" | |||
There was a problem hiding this comment.
It thought we decided to just keep the lambda names?
There was a problem hiding this comment.
that would require updating the names of the docker images first for this PR to work
fn/lambda.go
Outdated
| opts := createImageOptions{ | ||
| Name: functionName, | ||
| Base: fmt.Sprintf("iron/lambda-%s", *function.Configuration.Runtime), | ||
| Base: fmt.Sprintf("lambda-%s", *function.Configuration.Runtime), |
There was a problem hiding this comment.
the init produces
runtime: lambda-node
This serves the same purpose
There was a problem hiding this comment.
I don't even think this will pull any image though regardless, since you don't even have a docker hub username anymore. Let's assume we'll push the images with the following naming: iron/functions-lambda:{aws_name}
fn/lambda.go
Outdated
| } | ||
|
|
||
| var ( | ||
| runtimeImportHandlers = map[string]func(functionName, tmpFileName string, opts *createImageOptions) ([]fileLike, error){ | ||
| "nodejs": basicImportHandler, | ||
| "node": basicImportHandler, |
There was a problem hiding this comment.
Again requires updating the image names for this to work
treeder
suggested changes
Mar 23, 2017
treeder
approved these changes
Mar 24, 2017
martinpinto
pushed a commit
to martinpinto/functions
that referenced
this pull request
Mar 29, 2017
* Fix lambda import * more updates * more changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.