Turns the upgrade-insecure-requests directive off in development mode #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
When this is on, safari forces an https connection to the server. This is not ideal for development as it requires a valid SSL certificate. This is turned off in development mode.
patnir
force-pushed
the
rahul/turn-upgrade-insecure-requests-off-in-dev
branch
from
8251da2
to
a952594
Compare
dgca
approved these changes
Sep 4, 2024
dgca
reviewed
Sep 4, 2024
next.config.js
Outdated
| @@ -11,6 +11,8 @@ const nextConfig = { | |||
| }, | |||
| }, | |||
| async headers() { | |||
| const isDev = process.env.NEXT_PUBLIC_ORIGIN !== 'https://ironfish.network/'; | |||
There was a problem hiding this comment.
suggestion: I think the more common way of checking for this is proecss.env.NODE_ENV === "development"
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
When this is on, safari forces an https connection to the server. This is not ideal for development as it requires a valid SSL certificate. This is turned off in development mode.
Reminder: If content (docs, blogs, pages) is moved or renamed, please ensure there are no broken links.