Add documentation for memoHex in RPCS #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NullSoldier
added
the
waiting on deploy
hughy
reviewed
Feb 21, 2024
Comment on lines
20
to
21
| memo: string | ||
| memoHex: string |
There was a problem hiding this comment.
need to mark these as optional
Comment on lines
16
to
17
| memo: string | ||
| memoHex: string |
| @@ -40,6 +41,8 @@ Creating a raw transaction does not require a spend key. They are not added to t | |||
| } | |||
| ``` | |||
|
|
|||
| > **Note:** outputs.memoHex is a hex encoded buffer with a max length of 32 bytes | |||
There was a problem hiding this comment.
I think this could be a bit confusing since the parameter is a string in the RPC requests
maybe is a hex-encoded string with a max length of 64 characters? We could also say that the string is equivalent to a 32 byte buffer
There was a problem hiding this comment.
Also the memo field has the same limitation, this would make me think you could fit more in the memo field.
hughy
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.