encrypts multisig server messages #5470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-if
approved these changes
Oct 2, 2024
uses xchacha20poly1305 to encrypt all string fields in messages sent to multisig server client decrypts string fields in messages received from multisig server derives the client key from a passphrase and the session ID (uses the bytes of the session ID, which is a UUID, for the salt and nonce). ensures that any client in the session can derive the key if they have the passphrase. adds passphrase flags and prompts to dkg:create and multisig:sign NOTE: numeric fields, like minSigners, are not currently encrypted Closes IFL-3013
hughy
force-pushed
the
feat/hughy/multisig-server-encryption
branch
from
94fd082
to
3108a63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
uses xchacha20poly1305 to encrypt all string fields in messages sent to multisig server
client decrypts string fields in messages received from multisig server
derives the client key from a passphrase and the session ID (uses the bytes of the session ID, which is a UUID, for the salt and nonce). ensures that any client in the session can derive the key if they have the passphrase.
adds passphrase flags and prompts to dkg:create and multisig:sign
NOTE: numeric fields, like minSigners, are not currently encrypted
NOTE also: this encrypts the fields rather than the entire message so that the server can still distinguish between identities, publlc packages, etc. in its session state
Closes IFL-3013
Testing Plan
manual testing:
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.