Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ironfish): Add encrypt method for account #5247

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

rohanjadvani
Copy link
Member

@rohanjadvani rohanjadvani commented Aug 13, 2024

Summary

  • Add encrypt method for Account
  • Remove KEY_LENGTH duplicate constant (mutual imports were messing this up)
  • Refactor interface to type to fix test

Testing Plan

Unit tests

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes

@rohanjadvani rohanjadvani self-assigned this Aug 13, 2024
@rohanjadvani rohanjadvani marked this pull request as ready for review August 13, 2024 18:12
@rohanjadvani rohanjadvani requested a review from a team as a code owner August 13, 2024 18:12
@rohanjadvani rohanjadvani merged commit e734cc5 into staging Aug 13, 2024
4 checks passed
@rohanjadvani rohanjadvani deleted the rohan/ifl-2842-add-encrypt-method-to-account branch August 13, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants