Import duplicate spending key says account name #5115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiflabs
approved these changes
Jul 8, 2024
NullSoldier
force-pushed
the
jason/import-error
branch
from
f1812ac
to
bda3602
Compare
When importing an account twice, it would not print out the name of the account with the duplicate spending key. This will now include that in the message. It also improves tests to check the error type instead of error message. We should avoid testing error messages in tests if there is a proper typed error to check.
NullSoldier
force-pushed
the
jason/import-error
branch
from
bda3602
to
658ba45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When importing an account twice, it would not print out the name of the account with the duplicate spending key. This will now include that in the message.
It also improves tests to check the error type instead of error message. We should avoid testing error messages in tests if there is a proper typed error to check.
Created in response to this, #5084
Testing Plan
ironfish wallet:create foobarironfish wallet:export foobar --mnemonicironfish wallet:import --name bazmonkey <mnemonic>foobarwhich already contains the mneomonicAccount (foobar) already exists with provided spending keyironfish wallet:delete foobarDocumentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.