Implement wallet/multisig/dkg/round1 RPC
#4885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiflabs
force-pushed
the
andrea/multisig-dkg-switch-if-frost-branch
branch
from
8a2bdbb
to
3773312
Compare
andiflabs
force-pushed
the
andrea/multisig-dkg-round-1-rpc
branch
from
ee06580
to
95d2929
Compare
hughy
reviewed
Apr 9, 2024
ironfish-rust-nodejs/src/multisig.rs
Outdated
Comment on lines
380
to
373
| if min_signers > max_signers { | ||
| return Err(to_napi_err( | ||
| "min_signers exceeds the number of participants", | ||
| )); | ||
| } | ||
|
|
||
| let mut rng = thread_rng(); | ||
| let (secret_package, public_package) = dkg::part1( | ||
| self_identity.to_frost_identifier(), | ||
| max_signers, | ||
| min_signers, | ||
| &mut rng, | ||
| ) | ||
| .map_err(to_napi_err)?; |
There was a problem hiding this comment.
wondering if we should move logic like this into ironfish-rust or ironfish-frost as we add more validation, checksums, etc.
I'm not sure if having it in ironfish-rust-nodejs will make it difficult to use if someone were trying to build on top of it outside of the TypeScript SDK
There was a problem hiding this comment.
Created iron-fish/ironfish-frost#46 to move the functionality over to ironfish-frost
andiflabs
changed the base branch from
andrea/multisig-dkg-switch-if-frost-branch
to
andrea/update-ironfish-frost
andiflabs
force-pushed
the
andrea/multisig-dkg-round-1-rpc
branch
2 times, most recently
from
34d0f30
to
fe43358
Compare
andiflabs
force-pushed
the
andrea/update-ironfish-frost
branch
from
51cee64
to
d46621b
Compare
andiflabs
force-pushed
the
andrea/multisig-dkg-round-1-rpc
branch
from
e4ceb5f
to
37e5aaa
Compare
rohanjadvani
approved these changes
Apr 10, 2024
andiflabs
force-pushed
the
andrea/update-ironfish-frost
branch
from
d46621b
to
f0bbcff
Compare
andiflabs
force-pushed
the
andrea/multisig-dkg-round-1-rpc
branch
from
37e5aaa
to
c708b29
Compare
hughy
approved these changes
Apr 10, 2024
andiflabs
force-pushed
the
andrea/multisig-dkg-round-1-rpc
branch
from
c708b29
to
219f47b
Compare
andiflabs
force-pushed
the
andrea/multisig-dkg-round-1-rpc
branch
from
219f47b
to
fb02035
Compare
rohanjadvani
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.