Add RPC for validating address #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
are you going to add rpc client support? |
ygao76
reviewed
Apr 25, 2023
| IsValidPublicAddressRequestSchema, | ||
| (request): void => { | ||
| request.end({ | ||
| valid: isValidPublicAddress(request.data.address), |
There was a problem hiding this comment.
I think its better to use this isValidPublicAddress
ironfish/ironfish/src/wallet/validator.ts
Line 12 in bb99849
There was a problem hiding this comment.
Yeah, it won't practically make a difference, but I think this is a good idea. We should have a cleanup task for standardizing all uses of the function to go through the SDK, and this function is exported through the SDK + used in the wallet
There was a problem hiding this comment.
Yea sounds good I updated it
holahula
approved these changes
Apr 25, 2023
hughy
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding endpoint for validating a public address
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.