Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opening the repl without opening the DB #3753

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Allow opening the repl without opening the DB #3753

merged 1 commit into from
Apr 7, 2023

Conversation

NullSoldier
Copy link
Contributor

Summary

You can now use --no-db to not load the databases. This gives you access to the SDK without needing to load the data directory.

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

@NullSoldier NullSoldier requested a review from a team as a code owner April 6, 2023 13:40
You can now use --no-db to not load the databases. This gives you access
to the SDK without needing to load the data directory.
Copy link
Contributor

@hughy hughy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of this! Should we update the text that's logged on start if the db isn't open? Most (all?) of the examples won't work without a database

@NullSoldier
Copy link
Contributor Author

I think it's fine, because those examples are still valid.

  1. The examples show me how to do things
  2. Only advanced user will use --no-opendb
  3. They'll know to call node.open() if they want to use the DB
  4. They'll get an nice error saying the DB is not open

@hughy hughy merged commit ff39037 into staging Apr 7, 2023
@hughy hughy deleted the jason/test4 branch April 7, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants