-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(ironfish): Add RPC route for chain:broadcast
#3742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holahula
changed the title
feature(ironfish): add rpc route for broadcasting txns
feature(ironfish): Add RPC route for Apr 4, 2023
chain:broadcast
NullSoldier
reviewed
Apr 5, 2023
NullSoldier
reviewed
Apr 5, 2023
NullSoldier
reviewed
Apr 5, 2023
NullSoldier
reviewed
Apr 5, 2023
NullSoldier
reviewed
Apr 5, 2023
NullSoldier
reviewed
Apr 5, 2023
NullSoldier
reviewed
Apr 5, 2023
NullSoldier
reviewed
Apr 5, 2023
NullSoldier
reviewed
Apr 5, 2023
NullSoldier
reviewed
Apr 5, 2023
holahula
changed the title
feature(ironfish): Add RPC route for
[wip] feature(ironfish): Add RPC route for Apr 5, 2023
chain:broadcast
chain:broadcast
holahula
force-pushed
the
holahula/feat/chain-broadcast-rpc
branch
3 times, most recently
from
April 5, 2023 18:41
303d99e
to
d89d5ef
Compare
holahula
changed the title
[wip] feature(ironfish): Add RPC route for
feature(ironfish): Add RPC route for Apr 5, 2023
chain:broadcast
chain:broadcast
hughy
reviewed
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment on error handling in the CLI command, but this looks great!
NullSoldier
reviewed
Apr 6, 2023
NullSoldier
reviewed
Apr 6, 2023
NullSoldier
reviewed
Apr 6, 2023
holahula
force-pushed
the
holahula/feat/chain-broadcast-rpc
branch
from
April 6, 2023 15:08
a844686
to
911d467
Compare
@hughy @NullSoldier all pr comments have been addressed |
hughy
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
dguenther
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an RPC route and accompanying CLI command (
ironfish chain:broadcast
) for broadcasting a transaction to the network.Closes IFL-411
Testing Plan
Manual test:
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
iron-fish/website#357
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.