Change importexport tests to use test datadir #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanJRichard
approved these changes
Apr 4, 2023
hughy
approved these changes
Apr 4, 2023
| @@ -5,6 +5,8 @@ set -e # exit immediately if anything returns with non-zero exit code | |||
| # Change working directory to the script's directory | |||
| cd "$(dirname "$0")" | |||
|
|
|||
| DATA_DIR="../testdbs/importexport" | |||
There was a problem hiding this comment.
nit - I think if you use IRONFISH_DATA_DIR here you won't need to set it in each command
I noticed this was failing to run because my datadir was a later version. I see it's using my actual datadir which I have my real data in. Changing this so it does not use a users real database to perform tests, and instead uses a test datadir.
NullSoldier
force-pushed
the
jason/datadir
branch
from
1d34f1e
to
3b97f8d
Compare
jowparks
pushed a commit
that referenced
this pull request
Apr 5, 2023
I noticed this was failing to run because my datadir was a later version. I see it's using my actual datadir which I have my real data in. Changing this so it does not use a users real database to perform tests, and instead uses a test datadir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed this was failing to run because my datadir database was a later version. I see it's using my actual datadir which I have my real data in. Changing this so it does not use a users real database to perform tests, and instead uses a test datadir.
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.