Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message when running from a windows 32-bit install #3649

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

dguenther
Copy link
Member

Summary

This was an error that came up in slack: https://iron-fish.slack.com/archives/C02PF56HESK/p1678727391843899 I suspect some people are installing 32-bit versions by mistake.

If they do actually have 32-bit Windows computers, those would be at least 10 years old, which likely will end up struggling to run Iron Fish anyway (particularly since we recommend >4GB RAM)

Testing Plan

  • Tested on a Windows computer with 32-bit Node.js installed to ensure the error popped up
  • Tested on a Windows computer with 64-bit Node.js installed to ensure no error appeared

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[x] Yes

I updated the onboarding docs to specifically call out 64-bit installs: https://ironfish.network/docs/onboarding/installation-iron-fish

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

@dguenther dguenther requested a review from a team as a code owner March 14, 2023 22:56
@dguenther dguenther merged commit 0841a91 into staging Mar 14, 2023
@dguenther dguenther deleted the block-win-32bit branch March 14, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants