Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves output of stop command #3641

Merged
merged 1 commit into from
Mar 11, 2023
Merged

improves output of stop command #3641

merged 1 commit into from
Mar 11, 2023

Commits on Mar 11, 2023

  1. improves output of stop command

    the 'stopNode' RPC shuts down the node before returning a response, so the cli
    client receives an error from the lost connection. IronfishCommand handles RPC
    connection errors and outputs 'Cannot connect to your node, start your node
    first.'. this is confusing both because we were able to connect to the node and
    because we successfully stopped it.
    
    the stop command also silences RPC connection errors, so nothing is output if
    the node is already stopped when stop is run.
    
    - returns a response from stopNode before shutting down the node
    - removes error handling from 'client.connect' in stop command since the
      IronfishCommand abstract class handles these errors
    - adds output to 'stop' command indicating that it asks the node to shut down
    hughy committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    7ca480e View commit details
    Browse the repository at this point in the history