adds bech32 to dependencies for @ironfish/sdk #3608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`yarn add bech32` after installing @ironfish/sdk, bech32 module cannot be found.
|
We define util functions that use bech32 in the SDK, but it looks like we only use them in the CLI right now. An alternative to this dependency is to move those util definitions to the CLI. |
dguenther
approved these changes
Mar 6, 2023
|
Confirmed that this fixes the issue by testing iron-fish/proxy-example#1 by installing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
yarn add bech32after installing @ironfish/sdk, bech32 module cannot be found (e.g., https://discord.com/channels/771503434028941353/831945060777852998/1082211129796874311)
Testing Plan
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.