chore: bump @napi-rs/blake-hash #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes some performance improvements like using JsBuffer instead of Buffer, which we have done in our own NAPI code to minimize memory leaks. This version also includes a fix to make Iron Fish run on systems with non-standard ldd path, like NixOS.
rohanjadvani
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This includes some performance improvements like using JsBuffer instead of Buffer, which we have done in our own NAPI code to minimize memory leaks. This version also includes a fix to make Iron Fish run on systems with non-standard ldd path, like NixOS.
Testing Plan
Manually tested with some nodes, including mining and syncing
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.