feat: Don't send outbound messages that exceed the max size #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a check to all outbound messages to ensure they fit within the MAX_MESSAGE_SIZE. This ensures a node is not sending invalid messages, intentionally or not.
mat-if
force-pushed
the
mat/limit-send-size
branch
from
2be999b
to
3366568
Compare
mat-if
commented
Feb 28, 2023
dguenther
reviewed
Feb 28, 2023
dguenther
approved these changes
Feb 28, 2023
dguenther
pushed a commit
that referenced
this pull request
Mar 8, 2023
* feat: Don't send outbound messages that exceed the max size This adds a check to all outbound messages to ensure they fit within the MAX_MESSAGE_SIZE. This ensures a node is not sending invalid messages, intentionally or not. * fix: re-add connection-specific metrics * fix: add exhaustive enum checking for ConnectionType * fix: lint and bind instance method * add test for happy path
dguenther
pushed a commit
that referenced
this pull request
Mar 8, 2023
* feat: Don't send outbound messages that exceed the max size This adds a check to all outbound messages to ensure they fit within the MAX_MESSAGE_SIZE. This ensures a node is not sending invalid messages, intentionally or not. * fix: re-add connection-specific metrics * fix: add exhaustive enum checking for ConnectionType * fix: lint and bind instance method * add test for happy path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a check to all outbound messages to ensure they fit within the MAX_MESSAGE_SIZE. This ensures a node is not sending invalid messages, intentionally or not.
Testing Plan
Unit test
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.